httpd: disable Deflater middleware by default on Perl <5.18

[public-inbox.git] / script / public-inbox-httpd

diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index b2464f4efc0d31be9909c872c3969353e33768c6..9b869f906032ed8e090f60d3c92ca62792ab47de 100755 (executable)
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -24,7 +24,13 @@ my $refresh = sub {
                my $www = PublicInbox::WWW->new;
                $www->preload;
                $app = builder {
-                       eval {
+                       # Perl 5.16.3 leaks in our "push" response code path
+                       # (e.g. Qspawn) due to something in
+                       # Plack::Util::response_cb, regardless of whether the
+                       # client is sending Accept-Encoding:gzip requests.
+                       # perl5180delta documents many leak fixes, so assume
+                       # 5.18+ is safe for now and bump the check as-need:
+                       $] >= 5.018000 and eval {
                                enable 'Deflater',
                                        content_type => [ qw(
                                                text/html