PublicInbox::Inbox objects have minimal dependencies, so
drop code to support old tests which existed before the
PublicInbox::Inbox object came into existence.
Eric Wong [Fri, 14 Jun 2019 16:42:26 +0000 (16:42 +0000)]
t/www_listing: favor HTTP::Tiny over Net::HTTP
More testers are likely to have HTTP::Tiny than Net::HTTP, since
HTTP::Tiny is a dual-life module and distributed with Perl since
Perl 5.14 (2011-05-14), whereas Net::HTTP will likely live in
a separate package forever.
Eric Wong [Fri, 14 Jun 2019 16:25:39 +0000 (16:25 +0000)]
Merge remote-tracking branch 'origin/reshard' into next
* origin/reshard:
xcpdb: support resharding v2 repos
xcpdb: use destination shard as progress prefix
xapcmd: preserve indexlevel based on the destination
v2writable: use a smaller default for Xapian partitions
Eric Wong [Fri, 14 Jun 2019 16:23:13 +0000 (16:23 +0000)]
Merge remote-tracking branch 'origin/manifest' into next
* origin/manifest:
git: ensure ->modified returns an integer
www: support $INBOX/git/$EPOCH.git for v2 cloning
www: wire up /$INBOX/manifest.js.gz, too
wwwlisting: generate grokmirror-compatible manifest.js.gz
wwwlisting: allow hiding entries from manifest
Eric Wong [Thu, 13 Jun 2019 00:29:37 +0000 (00:29 +0000)]
xcpdb: support resharding v2 repos
v2 repos are sometimes created on machines where CPU
parallelization exceeds the capability of the storage devices.
In that case, users may reshard the Xapian DB to any smaller,
positive integer to avoid excessive overhead and contention when
bottlenecked by slow storage.
Resharding can also be used to increase shard count after
hardware upgrades.
Eric Wong [Wed, 12 Jun 2019 00:35:32 +0000 (00:35 +0000)]
v2writable: use a smaller default for Xapian partitions
Apparently 16 CPUs (probably HT) and SATA storage is common
these days. Having excessive Xapian partitions leads to
contention and excessive FD/space use. So set a smaller
default but continue allowing user-specified values to bump
this up.
Eric Wong [Thu, 13 Jun 2019 08:10:02 +0000 (08:10 +0000)]
git: remove cat_file sub callback interface
We weren't using it, and in retrospect, it makes no sense to use
this API cat_file for giant responses which can't read quickly
with minimal context-switching (or sanely fit into memory for
Email::Simple/Email::MIME).
For giant blobs which we don't want slurped in memory, we'll
spawn a short-lived git-cat-file process like we do in ViewVCS.
Otherwise, monopolizing a git-cat-file process for a giant
blob is harmful to other PSGI/NNTP users.
A better interface is coming which will be more suitable for
for batch processing of "small" objects such as commits and
email blobs.
Eric Wong [Fri, 14 Jun 2019 00:27:31 +0000 (00:27 +0000)]
nntp: filter out duplicate Message-IDs for leafnode
It's the unfortunate reality that there are some clients which
reuse Message-IDs (in which we generate + use another) or set
multiple Message-IDs on their own. While the v2 format
addresses that, NNTP clients such as leafnode are not always
prepared to deal with that case.
So, ensure NNTP clients only see a single Message-ID, and
show the others as 'X-Alt-Message-ID'.
Eric Wong [Thu, 13 Jun 2019 20:46:52 +0000 (20:46 +0000)]
nntp: ensure Message-ID is not folded for leafnode
Leafnode cannot handle Message-ID headers which are too long and
require folding via Email::Simple::Header. Since there are
already many of these messages in git with the header already
folded, we need to handle the unfolding when emitting the
message via NNTP.
As far as we know, Leafnode is the only client software
incapable of handling this case.
Eric Wong [Thu, 13 Jun 2019 02:26:30 +0000 (02:26 +0000)]
doc: update dependencies for CentOS 7.x
Digest::SHA is the most notable missing package at runtime
for a minimal system.
Tests don't run at all without Test::Simple (or Test::More).
Plack::Test is also a separate package, too...
Also, the package for IO::Compress::Gzip should be IO::Compress;
as perl-PerlIO-gzip is a different thing entirely which is not
relevant to our needs.
Test::HTTP::Server::Simple doesn't seem required at all for Plack
tests.
ExtUtils::MakeMaker needs to be documented as a install dependency
for people installing this, too; since AFAIK public-inbox is not
yet in any distros.
Eric Wong (Contractor, The Linux Foundation) [Mon, 10 Jun 2019 18:09:27 +0000 (18:09 +0000)]
edit: drop unwanted headers before noop check
mutt will set Content-Length, Lines, and Status headers
unconditionally, so we need to account for that before
doing header comparisons to avoid making expensive changes
when noop edits are made.
Eric Wong [Mon, 10 Jun 2019 03:21:37 +0000 (03:21 +0000)]
ds: stop caring about event flags set by epoll/poll/kqueue
If we got something to write, then write it. Otherwise, try
reading; and continue dealing with errors which normally occur
along the way.
Trying to read requests while we need to buffer in luserspace
is suicidal from a memory management standpoint.
The only adjustment needed for existing callers is EvCleanup;
where we need to ensure we're always calling the dummy
EvCleanup::event_write callback to accomplish nothing.
Eric Wong [Mon, 10 Jun 2019 03:02:11 +0000 (03:02 +0000)]
ds: do not distinguish between POLLHUP and POLLERR
In my experience, both are worthless as any normal read/write
call path will be wanting to check errors and deal with them
appropriately; so we can just call event_read, for now.
Eventually, there'll probably be only one callback for dealing
with all in/out/err/hup events to simplify logic, especially w.r.t
TLS socket negotiation.
Eric Wong [Mon, 10 Jun 2019 02:34:48 +0000 (02:34 +0000)]
nntp: use sysread to append to existing buffer
We already do this in PublicInbox::HTTP, as it's superior to
DS::read in this regard. Initially (when I started writing
NNTP.pm, I wanted to use Danga::Socket's read buffering and
push_back_read (removed in DS) but quickly figured out it wasn't
useful at all for dealing with trickling clients.
Eric Wong [Mon, 10 Jun 2019 02:07:26 +0000 (02:07 +0000)]
ds: remove {fd} field
Storing the file descriptor was redundant as we can quickly call
fileno($self->{sock}) and not have to store an extra hash table
entry. Multiple sources of truth leads to confusion, confusion
leads to bugs.
#!/usr/bin/perl -w
use Benchmark qw(:all);
use Errno qw(EAGAIN EINTR);
my ($r, $w);
pipe($r, $w) or die 'pipe';
require IO::Handle;
$r->blocking(0);
my $buf;
my $n = 30000;
timethese(30, {
hash_hit => sub {
sysread($r, $buf, 1);
for (0..$n) {
next if $!{EAGAIN};
die 'FAIL';
}
}
,
'cmp_eq' => sub {
sysread($r, $buf, 1);
for (0..$n) {
next if $! == EAGAIN;
die 'FAIL';
}
},
hash_miss => sub {
sysread($r, $buf, 1);
for (0..$n) {
die 'FAIL' if $!{EINTR};
}
},
'cmp_ne' => sub {
sysread($r, $buf, 1);
for (0..$n) {
die 'FAIL' if $! == EINTR;
}
},
});
Eric Wong [Mon, 10 Jun 2019 01:33:30 +0000 (01:33 +0000)]
ds: simplify write buffer accounting
Keeping track of write_buf_size was redundant and pointless when
we can simply check the number of elements in the buffer array.
Multiple sources of truth leads to confusion; confusion leads to
bugs.
Finally, rename the prefixes to 'wbuf' to ensure we loudly
(instead of silently) break any external dependencies being
ported over from Danga::Socket, as further changes are pending.
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:41 +0000 (02:51 +0000)]
admin: remove warning arg for unconfigured inboxes
We no longer make -index warn on it, no other code uses it;
and working on unconfigured inboxes is totally reasonable
for admins who are setting things up.
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:40 +0000 (02:51 +0000)]
v2writable: implement ->replace call
Much of the existing purge code is repurposed to a general
"replace" functionality.
->purge is simpler because it can just drop the information.
Unlike ->purge, ->replace needs to edit existing git commits (in
case of From: and Subject: headers) and reindex the modified
message.
We currently disallow editing of References:, In-Reply-To: and
Message-ID headers because it can cause bad side effects with
our threading (and our lack of rethreading support to deal with
excessive matching from incorrect/invalid References).
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:39 +0000 (02:51 +0000)]
import: switch to "replace_oids" interface for purge
Continuing the work by Eric Biederman in commit a118d58a402bd31b
("Import.pm: When purging replace a purged file with a zero length file"),
we can use a generic OID replacement mechanism to implement
purge.
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:37 +0000 (02:51 +0000)]
v2writable: consolidate overview and indexing call
It's one ugly sub with lots of parameters, but it's better
than calling a bunch of ugly subs with lots of parameters;
as we'll be needing to call it again when reindexing for
message replacements.
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:04 +0000 (04:31 +0000)]
www: wire up /$INBOX/manifest.js.gz, too
I can imagine myself just wanting to clone a single v2 inbox
and all its epochs without thinking about include/exclude
rules in a grokmirror config file.
Support on-demand generation of "/manifest.js.gz" for inboxes.
By default, this matches inboxes with URLs matching the given
request hostname by default.
This makes it easier to create full mirrors of several inboxes
without needing to configure static file serving.
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:02 +0000 (04:31 +0000)]
wwwlisting: allow hiding entries from manifest
Since we already have a mechanism for hiding repositories from
the WWW listing, we might as well support another one for hiding
repositories from the upcoming manifest.js.gz generation.
Eric Wong [Wed, 5 Jun 2019 01:26:55 +0000 (01:26 +0000)]
tighten up digit matches to ASCII for git output
While I don't expect git to suddenly start spewing non-ASCII
digits in places I'd expect ASCII, this would make things easier
for future hackers and reviewers.
Eric Wong [Tue, 4 Jun 2019 10:38:20 +0000 (10:38 +0000)]
Merge branch 'charclass'
* charclass: (24 commits)
www: require ASCII word characters for CSS filenames
www: require ASCII range for mbox downloads
githttpbackend: require ASCII in path
require ASCII digits for local FS items
www: require ASCII digit for git epoch
solver|viewdiff: restrict digit matches to ASCII
inbox: require ASCII digits for feedmax var
filter/rubylang: require ASCII digit for mailcount
msgtime: require ASCII digits for parsing dates
searchview: do not allow non-ASCII offsets and limits
githttpbackend: require Range:, Status: to be ASCII digits
view: require YYYYmmDD(HHMMSS) timestamps to be ASCII
newswww: only accept ASCII digits as article numbers
config: do not accept non-ASCII digits in cgitrc params
www: require ASCII filenames in git blob downloads
www: only emit ASCII chars in attachment filenames
wwwattach: only pass the charset through if ASCII
wwwlisting: require ASCII digit for port number
http: require SERVER_PORT to be ASCII digit
feed: only accept ASCII digits for ref~$N
...
Eric Wong [Tue, 4 Jun 2019 09:05:51 +0000 (09:05 +0000)]
www: require ASCII range for mbox downloads
We do not support many mboxrd download range specifications at
the moment; but parsing non-ASCII characters isn't planned.
This makes no difference aside from being able to return 404
slightly earlier than we would've in the past.
Eric Wong [Tue, 4 Jun 2019 08:58:32 +0000 (08:58 +0000)]
githttpbackend: require ASCII in path
We mainly support git-upload-pack; and maybe somebody uses
git-receive-pack with this. Perhaps other (experimental)
command names are acceptable. But it's unlikely anybody will
want Unicode command names for git services.
Eric Wong [Tue, 4 Jun 2019 08:30:55 +0000 (08:30 +0000)]
solver|viewdiff: restrict digit matches to ASCII
git would not generate non-ASCII digits to describe
hunk offsets, so don't waste more time than necessary
to make sense of non-ASCII digit chars for line offsets.
Eric Wong [Tue, 4 Jun 2019 02:04:32 +0000 (02:04 +0000)]
githttpbackend: require Range:, Status: to be ASCII digits
Non-ASCII digits would be interpreted as a zeroes as integers.
While we're at it, ensure the Status: code is an ASCII digit,
too; though I would not expect git-http-backend(1) or cgit(1)
start spewing non-ASCII digits at us.
Eric Wong [Tue, 4 Jun 2019 09:02:01 +0000 (09:02 +0000)]
www: require ASCII filenames in git blob downloads
Our Hval::to_filename sub has always been strict about emitting
ASCII-only characters for ViewVCS "raw" links.
However, somebody could manually generate a filename with
non-ASCII words for somebody else to download (we have no
cheap and fast way of mapping filenames back to blobs for
validation).
Eric Wong [Tue, 4 Jun 2019 02:04:28 +0000 (02:04 +0000)]
www: only emit ASCII chars in attachment filenames
We don't want to emit funky URLs which can be lost in
translation or cause problems with non-Unicode-aware
clients.
Then, don't accept non-ASCII filenames in URLs, since
a manually-generated URL/filename in attachment downloads
could be used for Unicode homographs to confuse folks who
down the attachment.
Eric Wong [Tue, 4 Jun 2019 08:20:40 +0000 (08:20 +0000)]
nntp: ensure we only handle ASCII whitespace
RFC3977 does not have provisions for whitespace beyond ASCII
TAB, SP, CR and LF. I doubt there's any NNTP clients broken
enough to be sending non-ASCII whitespace delimiters.
We're probably excessively liberal regarding TAB acceptance,
even; but it's probably too late to change at this point...
Eric Wong [Tue, 4 Jun 2019 02:04:21 +0000 (02:04 +0000)]
linkify: support Internationalized Domain Names in URLs
The "\w" character class in Perl matches any word characters
in the Unicode database, not just ASCII characters. So we
must be prepared for that and generate links to IDNs.
Eric Wong [Mon, 3 Jun 2019 09:04:01 +0000 (09:04 +0000)]
Merge remote-tracking branch 'origin/ds'
* origin/ds:
ds: remove PLCMap and per-socket PostLoopCallback
ds: drop write_set_watch field
ds: drop unused EVENT: label in epoll code path
ds: drop checks for invalid descriptors
ds: drop set_writer_func support
ds: add a note about planned future changes
ds: drop more unused subs