]> Sergey Matveev's repositories - public-inbox.git/log
public-inbox.git
5 years agosearch*: rename {partition} => {shard}
Eric Wong [Fri, 14 Jun 2019 17:42:57 +0000 (17:42 +0000)]
search*: rename {partition} => {shard}

Another step towards keeping our internal data structures
consistent with Xapian naming.

5 years agoxapcmd: update comments referencing "partitions"
Eric Wong [Fri, 14 Jun 2019 17:38:01 +0000 (17:38 +0000)]
xapcmd: update comments referencing "partitions"

Don't confuse future readers of our code.

5 years agov2: rename SearchIdxPart => SearchIdxShard
Eric Wong [Fri, 14 Jun 2019 17:35:04 +0000 (17:35 +0000)]
v2: rename SearchIdxPart => SearchIdxShard

Another step towards keeping our file and package names
consistent with Xapian terminology.

5 years agoinboxwritable: s/partitions/shards/ in local var
Eric Wong [Fri, 14 Jun 2019 17:31:28 +0000 (17:31 +0000)]
inboxwritable: s/partitions/shards/ in local var

More work towards being consistent with Xapian's own terminology

5 years agotests: change messages to use "shard" instead of partition
Eric Wong [Fri, 14 Jun 2019 08:02:32 +0000 (08:02 +0000)]
tests: change messages to use "shard" instead of partition

Another potentially user-facing piece made consistent with
Xapian terminology.

5 years agov2writable: rename {partitions} field to {shards}
Eric Wong [Fri, 14 Jun 2019 07:59:53 +0000 (07:59 +0000)]
v2writable: rename {partitions} field to {shards}

Our internal data structure should be consistent with Xapian
terminology.

5 years agov2writable: count_partitions => count_shards
Eric Wong [Fri, 14 Jun 2019 07:56:58 +0000 (07:56 +0000)]
v2writable: count_partitions => count_shards

Another step towards becoming consistent with Xapian terminology

5 years agosearchidxpart: start using "shard" in user-visible places
Eric Wong [Fri, 14 Jun 2019 07:55:35 +0000 (07:55 +0000)]
searchidxpart: start using "shard" in user-visible places

We'll name our process title with "shard" instead, and
update a few error messages and comments to match.

5 years agorename reference to git epochs as "partitions"
Eric Wong [Fri, 14 Jun 2019 07:51:45 +0000 (07:51 +0000)]
rename reference to git epochs as "partitions"

Try to remain consistent with our own documentation regarding
v2 git "epochs", first.

5 years agoadmin|xapcmd: user-facing messages say "shard"
Eric Wong [Fri, 14 Jun 2019 07:37:03 +0000 (07:37 +0000)]
admin|xapcmd: user-facing messages say "shard"

We're slowly getting rid of the word "partition" when it
comes to remain consistent with Xapian docs.

5 years agov2writable: update comments regarding xcpdb --reshard
Eric Wong [Fri, 14 Jun 2019 07:34:07 +0000 (07:34 +0000)]
v2writable: update comments regarding xcpdb --reshard

Using compact to change shard count was abandoned during
the v2 development phase.

5 years agodoc: rename our Xapian "partitions" to "shards"
Eric Wong [Fri, 14 Jun 2019 06:38:58 +0000 (06:38 +0000)]
doc: rename our Xapian "partitions" to "shards"

For consistency with Xapian documentation (in the "master"
branch).

5 years agov2writable: fix brainfart when capping NPROC_MAX_DEFAULT
Eric Wong [Fri, 14 Jun 2019 21:43:16 +0000 (21:43 +0000)]
v2writable: fix brainfart when capping NPROC_MAX_DEFAULT

Oops :x

5 years agosearch: require PublicInbox::Inbox ref here
Eric Wong [Fri, 14 Jun 2019 17:13:04 +0000 (17:13 +0000)]
search: require PublicInbox::Inbox ref here

No sense in supporting multiple methods of initialization
for an internal class.

5 years agosearchidx: require PublicInbox::Inbox (or InboxWritable) ref
Eric Wong [Fri, 14 Jun 2019 17:01:55 +0000 (17:01 +0000)]
searchidx: require PublicInbox::Inbox (or InboxWritable) ref

PublicInbox::Inbox objects have minimal dependencies, so
drop code to support old tests which existed before the
PublicInbox::Inbox object came into existence.

5 years agoMakefile.PL: add test scripts to syntax checks
Eric Wong [Fri, 14 Jun 2019 16:47:44 +0000 (16:47 +0000)]
Makefile.PL: add test scripts to syntax checks

I make syntax errors all the time :x

5 years agot/www_listing: favor HTTP::Tiny over Net::HTTP
Eric Wong [Fri, 14 Jun 2019 16:42:26 +0000 (16:42 +0000)]
t/www_listing: favor HTTP::Tiny over Net::HTTP

More testers are likely to have HTTP::Tiny than Net::HTTP, since
HTTP::Tiny is a dual-life module and distributed with Perl since
Perl 5.14 (2011-05-14), whereas Net::HTTP will likely live in
a separate package forever.

5 years agoedit: fix portability of editor invocation
Eric Wong [Mon, 10 Jun 2019 23:53:46 +0000 (23:53 +0000)]
edit: fix portability of editor invocation

The eval was unnecessary, and $0 can't be "--".
Tested with /bin/sh on FreeBSD 11.2

5 years agoMerge remote-tracking branch 'origin/reshard' into next
Eric Wong [Fri, 14 Jun 2019 16:25:39 +0000 (16:25 +0000)]
Merge remote-tracking branch 'origin/reshard' into next

* origin/reshard:
  xcpdb: support resharding v2 repos
  xcpdb: use destination shard as progress prefix
  xapcmd: preserve indexlevel based on the destination
  v2writable: use a smaller default for Xapian partitions

5 years agoMerge remote-tracking branch 'origin/manifest' into next
Eric Wong [Fri, 14 Jun 2019 16:23:13 +0000 (16:23 +0000)]
Merge remote-tracking branch 'origin/manifest' into next

* origin/manifest:
  git: ensure ->modified returns an integer
  www: support $INBOX/git/$EPOCH.git for v2 cloning
  www: wire up /$INBOX/manifest.js.gz, too
  wwwlisting: generate grokmirror-compatible manifest.js.gz
  wwwlisting: allow hiding entries from manifest

5 years agoMerge remote-tracking branch 'origin/edit' into next
Eric Wong [Fri, 14 Jun 2019 16:23:00 +0000 (16:23 +0000)]
Merge remote-tracking branch 'origin/edit' into next

* origin/edit:
  edit: unlink temporary file when done
  v2writable: replace: kill git processes before reindexing
  edit: drop unwanted headers before noop check
  edit|purge: improve output on rewrites
  edit: new tool to perform edits
  doc: document the --prune option for -index
  admin: expose ->config
  AdminEdit: move editability checks from -purge
  admin: beef up resolve_inboxes to handle purge options
  purge: start moving common options to AdminEdit module
  admin: remove warning arg for unconfigured inboxes
  v2writable: implement ->replace call
  import: switch to "replace_oids" interface for purge
  import: extract_author_info becomes extract_commit_info
  v2writable: consolidate overview and indexing call

5 years agoxcpdb: support resharding v2 repos
Eric Wong [Thu, 13 Jun 2019 00:29:37 +0000 (00:29 +0000)]
xcpdb: support resharding v2 repos

v2 repos are sometimes created on machines where CPU
parallelization exceeds the capability of the storage devices.

In that case, users may reshard the Xapian DB to any smaller,
positive integer to avoid excessive overhead and contention when
bottlenecked by slow storage.

Resharding can also be used to increase shard count after
hardware upgrades.

5 years agoxcpdb: use destination shard as progress prefix
Eric Wong [Wed, 12 Jun 2019 08:10:04 +0000 (08:10 +0000)]
xcpdb: use destination shard as progress prefix

For M:N resharding, we'll want to display the number from
the new shard number.

5 years agoxapcmd: preserve indexlevel based on the destination
Eric Wong [Wed, 12 Jun 2019 08:05:33 +0000 (08:05 +0000)]
xapcmd: preserve indexlevel based on the destination

To support M:N resharding, we need to ensure we store the
indexlevel in the destination shard, rather than the
originating one.

5 years agov2writable: use a smaller default for Xapian partitions
Eric Wong [Wed, 12 Jun 2019 00:35:32 +0000 (00:35 +0000)]
v2writable: use a smaller default for Xapian partitions

Apparently 16 CPUs (probably HT) and SATA storage is common
these days.  Having excessive Xapian partitions leads to
contention and excessive FD/space use.  So set a smaller
default but continue allowing user-specified values to bump
this up.

5 years agogit: remove cat_file sub callback interface
Eric Wong [Thu, 13 Jun 2019 08:10:02 +0000 (08:10 +0000)]
git: remove cat_file sub callback interface

We weren't using it, and in retrospect, it makes no sense to use
this API cat_file for giant responses which can't read quickly
with minimal context-switching (or sanely fit into memory for
Email::Simple/Email::MIME).

For giant blobs which we don't want slurped in memory, we'll
spawn a short-lived git-cat-file process like we do in ViewVCS.

Otherwise, monopolizing a git-cat-file process for a giant
blob is harmful to other PSGI/NNTP users.

A better interface is coming which will be more suitable for
for batch processing of "small" objects such as commits and
email blobs.

5 years agonntp: filter out duplicate Message-IDs for leafnode
Eric Wong [Fri, 14 Jun 2019 00:27:31 +0000 (00:27 +0000)]
nntp: filter out duplicate Message-IDs for leafnode

It's the unfortunate reality that there are some clients which
reuse Message-IDs (in which we generate + use another) or set
multiple Message-IDs on their own.  While the v2 format
addresses that, NNTP clients such as leafnode are not always
prepared to deal with that case.

So, ensure NNTP clients only see a single Message-ID, and
show the others as 'X-Alt-Message-ID'.

5 years agonntp: ensure Message-ID is not folded for leafnode
Eric Wong [Thu, 13 Jun 2019 20:46:52 +0000 (20:46 +0000)]
nntp: ensure Message-ID is not folded for leafnode

Leafnode cannot handle Message-ID headers which are too long and
require folding via Email::Simple::Header.  Since there are
already many of these messages in git with the header already
folded, we need to handle the unfolding when emitting the
message via NNTP.

As far as we know, Leafnode is the only client software
incapable of handling this case.

5 years agonntp: add Path: header for leafnode
Eric Wong [Thu, 13 Jun 2019 06:54:13 +0000 (06:54 +0000)]
nntp: add Path: header for leafnode

Apparently leafnode just needs any junk in the Path: header.
Lets not waste bandwidth and just use a single byte to keep
leafnode happy.

Cc: Dave Taht <dave@taht.net>
5 years agoMakefile.PL: "dsyn" target to check syntax of changed files
Eric Wong [Thu, 13 Jun 2019 03:44:41 +0000 (03:44 +0000)]
Makefile.PL: "dsyn" target to check syntax of changed files

We have lots of files and syntax-checking every single one of
them is slow.  Enable "perl -w" in the existing syntax check
while we're at it.

5 years agodoc: update dependencies for CentOS 7.x
Eric Wong [Thu, 13 Jun 2019 02:26:30 +0000 (02:26 +0000)]
doc: update dependencies for CentOS 7.x

Digest::SHA is the most notable missing package at runtime
for a minimal system.

Tests don't run at all without Test::Simple (or Test::More).
Plack::Test is also a separate package, too...

Also, the package for IO::Compress::Gzip should be IO::Compress;
as perl-PerlIO-gzip is a different thing entirely which is not
relevant to our needs.

Test::HTTP::Server::Simple doesn't seem required at all for Plack
tests.

ExtUtils::MakeMaker needs to be documented as a install dependency
for people installing this, too; since AFAIK public-inbox is not
yet in any distros.

5 years agot/common.perl: fix error message for git requirements
Eric Wong [Thu, 13 Jun 2019 01:53:18 +0000 (01:53 +0000)]
t/common.perl: fix error message for git requirements

And enable strict + warnings in the scope of t/common.perl, too.

5 years agosearchmsg: remove unused ->get subroutine
Eric Wong [Thu, 13 Jun 2019 01:49:11 +0000 (01:49 +0000)]
searchmsg: remove unused ->get subroutine

It's obsolete and unusable since our search schema version 15;
which made the Xapian document ID correspond to the NNTP article
number.

5 years agosearchidx: improve error message when Xapian fails
Eric Wong [Wed, 12 Jun 2019 00:18:01 +0000 (00:18 +0000)]
searchidx: improve error message when Xapian fails

Make it easier to detect if a partition is corrupt.

5 years agoedit: unlink temporary file when done
Eric Wong (Contractor, The Linux Foundation) [Tue, 11 Jun 2019 18:34:58 +0000 (18:34 +0000)]
edit: unlink temporary file when done

We don't need to leave temporary files lying around.

5 years agov2writable: replace: kill git processes before reindexing
Eric Wong (Contractor, The Linux Foundation) [Mon, 10 Jun 2019 21:43:52 +0000 (21:43 +0000)]
v2writable: replace: kill git processes before reindexing

Xapian on Linux <3.15 has trouble with coprocesses since it used
fork() for locking and would hold onto pipes used for git
unnecessarily.

5 years agoedit: drop unwanted headers before noop check
Eric Wong (Contractor, The Linux Foundation) [Mon, 10 Jun 2019 18:09:27 +0000 (18:09 +0000)]
edit: drop unwanted headers before noop check

mutt will set Content-Length, Lines, and Status headers
unconditionally, so we need to account for that before
doing header comparisons to avoid making expensive changes
when noop edits are made.

5 years agoedit|purge: improve output on rewrites
Eric Wong (Contractor, The Linux Foundation) [Mon, 10 Jun 2019 16:58:55 +0000 (16:58 +0000)]
edit|purge: improve output on rewrites

Fill in undef as "(unchanged)" when displaying commits
and prefix the epoch name.

5 years agods: stop caring about event flags set by epoll/poll/kqueue
Eric Wong [Mon, 10 Jun 2019 03:21:37 +0000 (03:21 +0000)]
ds: stop caring about event flags set by epoll/poll/kqueue

If we got something to write, then write it.  Otherwise, try
reading; and continue dealing with errors which normally occur
along the way.

Trying to read requests while we need to buffer in luserspace
is suicidal from a memory management standpoint.

The only adjustment needed for existing callers is EvCleanup;
where we need to ensure we're always calling the dummy
EvCleanup::event_write callback to accomplish nothing.

5 years agods: do not distinguish between POLLHUP and POLLERR
Eric Wong [Mon, 10 Jun 2019 03:02:11 +0000 (03:02 +0000)]
ds: do not distinguish between POLLHUP and POLLERR

In my experience, both are worthless as any normal read/write
call path will be wanting to check errors and deal with them
appropriately; so we can just call event_read, for now.

Eventually, there'll probably be only one callback for dealing
with all in/out/err/hup events to simplify logic, especially w.r.t
TLS socket negotiation.

5 years agods: remove read method, here, too
Eric Wong [Mon, 10 Jun 2019 02:39:24 +0000 (02:39 +0000)]
ds: remove read method, here, too

Since we stop using it in NNTP, we don't need it at all.

5 years agonntp: use sysread to append to existing buffer
Eric Wong [Mon, 10 Jun 2019 02:34:48 +0000 (02:34 +0000)]
nntp: use sysread to append to existing buffer

We already do this in PublicInbox::HTTP, as it's superior to
DS::read in this regard.  Initially (when I started writing
NNTP.pm, I wanted to use Danga::Socket's read buffering and
push_back_read (removed in DS) but quickly figured out it wasn't
useful at all for dealing with trickling clients.

5 years agods: remove steal_socket method
Eric Wong [Mon, 10 Jun 2019 02:18:44 +0000 (02:18 +0000)]
ds: remove steal_socket method

We won't be needing it, not even for TLS support.

5 years agods: remove {fd} field
Eric Wong [Mon, 10 Jun 2019 02:07:26 +0000 (02:07 +0000)]
ds: remove {fd} field

Storing the file descriptor was redundant as we can quickly call
fileno($self->{sock}) and not have to store an extra hash table
entry.  Multiple sources of truth leads to confusion, confusion
leads to bugs.

5 years agods: reduce Errno imports and drop ->close reason
Eric Wong [Tue, 4 Jun 2019 12:15:45 +0000 (12:15 +0000)]
ds: reduce Errno imports and drop ->close reason

ECONNRESET and EPIPE are common on a big Internet filled with
unreliable connections, and there's nothing our code can do
about it.

So no point in wasting code to log them and there are plenty of
tracing tools to choose from if such diagnostics are needed.

5 years agods: cleanup Errno imports and favor constant comparisons
Eric Wong [Mon, 3 Jun 2019 09:11:00 +0000 (09:11 +0000)]
ds: cleanup Errno imports and favor constant comparisons

Stop importing unused constants, and favor integer comparisons
of `$!' over `$!{EFOO}' hash lookups.  Integer comparisons are
slightly faster, even:

Benchmark: timing 30 iterations of cmp_eq, cmp_ne, hash_hit, hash_miss...
    cmp_eq:  1 wallclock secs ( 1.61 usr +  0.00 sys =  1.61 CPU) @ 18.63/s (n=30)
    cmp_ne:  2 wallclock secs ( 1.57 usr +  0.00 sys =  1.57 CPU) @ 19.11/s (n=30)
  hash_hit:  4 wallclock secs ( 3.85 usr +  0.00 sys =  3.85 CPU) @  7.79/s (n=30)
 hash_miss:  4 wallclock secs ( 3.74 usr +  0.00 sys =  3.74 CPU) @  8.02/s (n=30)

#!/usr/bin/perl -w
use Benchmark qw(:all);
use Errno qw(EAGAIN EINTR);
my ($r, $w);
pipe($r, $w) or die 'pipe';
require IO::Handle;
$r->blocking(0);
my $buf;
my $n = 30000;
timethese(30, {
hash_hit => sub {
sysread($r, $buf, 1);
for (0..$n) {
next if $!{EAGAIN};
die 'FAIL';
}
}
,
'cmp_eq' => sub {
sysread($r, $buf, 1);
for (0..$n) {
next if $! == EAGAIN;
die 'FAIL';
}
},
hash_miss => sub {
sysread($r, $buf, 1);
for (0..$n) {
die 'FAIL' if $!{EINTR};
}
},
'cmp_ne' => sub {
sysread($r, $buf, 1);
for (0..$n) {
die 'FAIL' if $! == EINTR;
}
},
});

5 years agods: simplify write buffer accounting
Eric Wong [Mon, 10 Jun 2019 01:33:30 +0000 (01:33 +0000)]
ds: simplify write buffer accounting

Keeping track of write_buf_size was redundant and pointless when
we can simply check the number of elements in the buffer array.
Multiple sources of truth leads to confusion; confusion leads to
bugs.

Finally, rename the prefixes to 'wbuf' to ensure we loudly
(instead of silently) break any external dependencies being
ported over from Danga::Socket, as further changes are pending.

5 years agogit: ensure ->modified returns an integer
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 00:53:29 +0000 (00:53 +0000)]
git: ensure ->modified returns an integer

We don't want to serialize timestamps as strings to JSON.
I only noticed this bug on a 32-bit system.

5 years agodoc: index.pod: fix mismatched =back
Eric Wong [Mon, 10 Jun 2019 02:44:07 +0000 (02:44 +0000)]
doc: index.pod: fix mismatched =back

5 years agodoc: generate manpage and HTML from -convert POD
Eric Wong [Sun, 9 Jun 2019 09:10:30 +0000 (09:10 +0000)]
doc: generate manpage and HTML from -convert POD

It's been written for over a year, but I forgot to include
it in the build so it did not get installed or put on the site.

5 years agodoc: clean-doc target removes *.8 manpages
Eric Wong [Sun, 9 Jun 2019 09:10:26 +0000 (09:10 +0000)]
doc: clean-doc target removes *.8 manpages

5 years agoedit: new tool to perform edits
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:47 +0000 (02:51 +0000)]
edit: new tool to perform edits

This wrapper around V2Writable->replace provides a user-interface
for editing messages as single-message mboxes (or the raw text
via $EDITOR).

5 years agodoc: document the --prune option for -index
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:46 +0000 (02:51 +0000)]
doc: document the --prune option for -index

We've had it around for a while, but I forgot to document it :x

5 years agoadmin: expose ->config
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:45 +0000 (02:51 +0000)]
admin: expose ->config

No point in forcing admin programs to reparse the config
themselves; and we won't support multiple instances of it;
unlike the WWW code.

5 years agoAdminEdit: move editability checks from -purge
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:44 +0000 (02:51 +0000)]
AdminEdit: move editability checks from -purge

We'll be reusing the same logic for -edit

5 years agoadmin: beef up resolve_inboxes to handle purge options
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:43 +0000 (02:51 +0000)]
admin: beef up resolve_inboxes to handle purge options

We'll be using this in -edit, and maybe other admin-oriented
tools for UI-consistency.

5 years agopurge: start moving common options to AdminEdit module
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:42 +0000 (02:51 +0000)]
purge: start moving common options to AdminEdit module

Editing and purging are similar operations involving history
rewrites, so there'll be common options and code between them.

5 years agoadmin: remove warning arg for unconfigured inboxes
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:41 +0000 (02:51 +0000)]
admin: remove warning arg for unconfigured inboxes

We no longer make -index warn on it, no other code uses it;
and working on unconfigured inboxes is totally reasonable
for admins who are setting things up.

5 years agov2writable: implement ->replace call
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:40 +0000 (02:51 +0000)]
v2writable: implement ->replace call

Much of the existing purge code is repurposed to a general
"replace" functionality.

->purge is simpler because it can just drop the information.
Unlike ->purge, ->replace needs to edit existing git commits (in
case of From: and Subject: headers) and reindex the modified
message.

We currently disallow editing of References:, In-Reply-To: and
Message-ID headers because it can cause bad side effects with
our threading (and our lack of rethreading support to deal with
excessive matching from incorrect/invalid References).

5 years agoimport: switch to "replace_oids" interface for purge
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:39 +0000 (02:51 +0000)]
import: switch to "replace_oids" interface for purge

Continuing the work by Eric Biederman in commit a118d58a402bd31b
("Import.pm: When purging replace a purged file with a zero length file"),
we can use a generic OID replacement mechanism to implement
purge.

5 years agoimport: extract_author_info becomes extract_commit_info
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:38 +0000 (02:51 +0000)]
import: extract_author_info becomes extract_commit_info

We will be reusing the same logic for extracting all
the authorship and commit title logic for edits; so
put it all into one sub.

5 years agov2writable: consolidate overview and indexing call
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 02:51:37 +0000 (02:51 +0000)]
v2writable: consolidate overview and indexing call

It's one ugly sub with lots of parameters, but it's better
than calling a bunch of ugly subs with lots of parameters;
as we'll be needing to call it again when reindexing for
message replacements.

5 years agowww: support $INBOX/git/$EPOCH.git for v2 cloning
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:05 +0000 (04:31 +0000)]
www: support $INBOX/git/$EPOCH.git for v2 cloning

And use it in manifest.js.

To ease maintaining mirrors with grokmirror(1), we can accept
a "git/" directory prefix before the epoch, and ".git" suffix
after the epoch number.

We maintain compatibility with "$INBOX/$EPOCH" cloning, of
course, and it's still easier-to-type on the command-line.

5 years agowww: wire up /$INBOX/manifest.js.gz, too
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:04 +0000 (04:31 +0000)]
www: wire up /$INBOX/manifest.js.gz, too

I can imagine myself just wanting to clone a single v2 inbox
and all its epochs without thinking about include/exclude
rules in a grokmirror config file.

5 years agowwwlisting: generate grokmirror-compatible manifest.js.gz
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:03 +0000 (04:31 +0000)]
wwwlisting: generate grokmirror-compatible manifest.js.gz

Support on-demand generation of "/manifest.js.gz" for inboxes.
By default, this matches inboxes with URLs matching the given
request hostname by default.

This makes it easier to create full mirrors of several inboxes
without needing to configure static file serving.

cf. https://git.kernel.org/pub/scm/utils/grokmirror/grokmirror.git

5 years agowwwlisting: allow hiding entries from manifest
Eric Wong (Contractor, The Linux Foundation) [Sun, 9 Jun 2019 04:31:02 +0000 (04:31 +0000)]
wwwlisting: allow hiding entries from manifest

Since we already have a mechanism for hiding repositories from
the WWW listing, we might as well support another one for hiding
repositories from the upcoming manifest.js.gz generation.

5 years agoscripts: add README to describe its purpose
Eric Wong [Wed, 5 Jun 2019 02:20:05 +0000 (02:20 +0000)]
scripts: add README to describe its purpose

Well, it could probably be moved to contrib...

5 years agoscripts: require ASCII digits in a few places
Eric Wong [Wed, 5 Jun 2019 02:01:29 +0000 (02:01 +0000)]
scripts: require ASCII digits in a few places

I haven't touched most these scripts in ages, but we might as well
purge \d usage from here, as well.

5 years agotighten up digit matches to ASCII for git output
Eric Wong [Wed, 5 Jun 2019 01:26:55 +0000 (01:26 +0000)]
tighten up digit matches to ASCII for git output

While I don't expect git to suddenly start spewing non-ASCII
digits in places I'd expect ASCII, this would make things easier
for future hackers and reviewers.

5 years agot: avoid "subtest" for Perl 5.10.1 compatibility
Eric Wong [Tue, 4 Jun 2019 11:29:39 +0000 (11:29 +0000)]
t: avoid "subtest" for Perl 5.10.1 compatibility

The version of Test::More from Perl 5.10.1 did not support
"subtest", and the earliest version which did is Perl 5.12.0

The good news is this gives me an excuse to parallelize
the indexlevels-mirror test by splitting it into two.
(it could be further split, even).

Update t/nntpd. to use PI_TEST_VERSION consistently while
we're at it.

5 years agoMerge branch 'charclass'
Eric Wong [Tue, 4 Jun 2019 10:38:20 +0000 (10:38 +0000)]
Merge branch 'charclass'

* charclass: (24 commits)
  www: require ASCII word characters for CSS filenames
  www: require ASCII range for mbox downloads
  githttpbackend: require ASCII in path
  require ASCII digits for local FS items
  www: require ASCII digit for git epoch
  solver|viewdiff: restrict digit matches to ASCII
  inbox: require ASCII digits for feedmax var
  filter/rubylang: require ASCII digit for mailcount
  msgtime: require ASCII digits for parsing dates
  searchview: do not allow non-ASCII offsets and limits
  githttpbackend: require Range:, Status: to be ASCII digits
  view: require YYYYmmDD(HHMMSS) timestamps to be ASCII
  newswww: only accept ASCII digits as article numbers
  config: do not accept non-ASCII digits in cgitrc params
  www: require ASCII filenames in git blob downloads
  www: only emit ASCII chars in attachment filenames
  wwwattach: only pass the charset through if ASCII
  wwwlisting: require ASCII digit for port number
  http: require SERVER_PORT to be ASCII digit
  feed: only accept ASCII digits for ref~$N
  ...

5 years agoMANIFEST: add examples/nginx_proxy
Eric Wong [Tue, 4 Jun 2019 10:37:52 +0000 (10:37 +0000)]
MANIFEST: add examples/nginx_proxy

5 years agoexamples: add sample nginx configuration
Ali Alnubani [Tue, 4 Jun 2019 09:22:27 +0000 (09:22 +0000)]
examples: add sample nginx configuration

The sample configuration can be used to proxy-pass requests
to public-inbox-httpd or to a standalone PSGI/Plack server.

5 years agowww: require ASCII word characters for CSS filenames
Eric Wong [Tue, 4 Jun 2019 10:19:34 +0000 (10:19 +0000)]
www: require ASCII word characters for CSS filenames

Allowing admins to set non-ASCII CSS filenames could
cause unnecessary problems for client and proxies.

5 years agowww: require ASCII range for mbox downloads
Eric Wong [Tue, 4 Jun 2019 09:05:51 +0000 (09:05 +0000)]
www: require ASCII range for mbox downloads

We do not support many mboxrd download range specifications at
the moment; but parsing non-ASCII characters isn't planned.
This makes no difference aside from being able to return 404
slightly earlier than we would've in the past.

5 years agogithttpbackend: require ASCII in path
Eric Wong [Tue, 4 Jun 2019 08:58:32 +0000 (08:58 +0000)]
githttpbackend: require ASCII in path

We mainly support git-upload-pack; and maybe somebody uses
git-receive-pack with this.  Perhaps other (experimental)
command names are acceptable.  But it's unlikely anybody will
want Unicode command names for git services.

5 years agorequire ASCII digits for local FS items
Eric Wong [Tue, 4 Jun 2019 08:40:34 +0000 (08:40 +0000)]
require ASCII digits for local FS items

In case some BOFH decides to randomly create directories
using non-ASCII digits all over the place.

5 years agowww: require ASCII digit for git epoch
Eric Wong [Tue, 4 Jun 2019 08:36:18 +0000 (08:36 +0000)]
www: require ASCII digit for git epoch

Don't inadvertantly serve git repos containing non-ASCII
digit characters.

5 years agosolver|viewdiff: restrict digit matches to ASCII
Eric Wong [Tue, 4 Jun 2019 08:30:55 +0000 (08:30 +0000)]
solver|viewdiff: restrict digit matches to ASCII

git would not generate non-ASCII digits to describe
hunk offsets, so don't waste more time than necessary
to make sense of non-ASCII digit chars for line offsets.

5 years agoinbox: require ASCII digits for feedmax var
Eric Wong [Tue, 4 Jun 2019 08:29:36 +0000 (08:29 +0000)]
inbox: require ASCII digits for feedmax var

Don't waste more cycles than necessary if somebody decides to
put non-ASCII digits in their ~/.public-inbox/config

5 years agofilter/rubylang: require ASCII digit for mailcount
Eric Wong [Tue, 4 Jun 2019 08:25:10 +0000 (08:25 +0000)]
filter/rubylang: require ASCII digit for mailcount

Unlikely to matter, but who knows...

5 years agomsgtime: require ASCII digits for parsing dates
Eric Wong [Tue, 4 Jun 2019 02:04:24 +0000 (02:04 +0000)]
msgtime: require ASCII digits for parsing dates

User input contains the darndest things.  Don't waste more time
than necessary trying to parse dates out of non-ASCII digits.

5 years agosearchview: do not allow non-ASCII offsets and limits
Eric Wong [Tue, 4 Jun 2019 02:04:33 +0000 (02:04 +0000)]
searchview: do not allow non-ASCII offsets and limits

Non-ASCII digits would be interpreted as zero when used as integers.

5 years agogithttpbackend: require Range:, Status: to be ASCII digits
Eric Wong [Tue, 4 Jun 2019 02:04:32 +0000 (02:04 +0000)]
githttpbackend: require Range:, Status: to be ASCII digits

Non-ASCII digits would be interpreted as a zeroes as integers.

While we're at it, ensure the Status: code is an ASCII digit,
too; though I would not expect git-http-backend(1) or cgit(1)
start spewing non-ASCII digits at us.

5 years agoview: require YYYYmmDD(HHMMSS) timestamps to be ASCII
Eric Wong [Tue, 4 Jun 2019 02:04:31 +0000 (02:04 +0000)]
view: require YYYYmmDD(HHMMSS) timestamps to be ASCII

Passing digits to `timegm' which it does not understand would
be a waste of time.

5 years agonewswww: only accept ASCII digits as article numbers
Eric Wong [Tue, 4 Jun 2019 02:04:30 +0000 (02:04 +0000)]
newswww: only accept ASCII digits as article numbers

Non-ASCII digits aren't specified in RFC3977 for article numbers;
so don't waste a trip to SQLite only to turn up empty.

5 years agoconfig: do not accept non-ASCII digits in cgitrc params
Eric Wong [Tue, 4 Jun 2019 02:04:29 +0000 (02:04 +0000)]
config: do not accept non-ASCII digits in cgitrc params

cgit uses atoi(3), and now we can retain compatibility.

5 years agowww: require ASCII filenames in git blob downloads
Eric Wong [Tue, 4 Jun 2019 09:02:01 +0000 (09:02 +0000)]
www: require ASCII filenames in git blob downloads

Our Hval::to_filename sub has always been strict about emitting
ASCII-only characters for ViewVCS "raw" links.

However, somebody could manually generate a filename with
non-ASCII words for somebody else to download (we have no
cheap and fast way of mapping filenames back to blobs for
validation).

5 years agowww: only emit ASCII chars in attachment filenames
Eric Wong [Tue, 4 Jun 2019 02:04:28 +0000 (02:04 +0000)]
www: only emit ASCII chars in attachment filenames

We don't want to emit funky URLs which can be lost in
translation or cause problems with non-Unicode-aware
clients.

Then, don't accept non-ASCII filenames in URLs, since
a manually-generated URL/filename in attachment downloads
could be used for Unicode homographs to confuse folks who
down the attachment.

5 years agowwwattach: only pass the charset through if ASCII
Eric Wong [Tue, 4 Jun 2019 02:04:27 +0000 (02:04 +0000)]
wwwattach: only pass the charset through if ASCII

AFAIK all names of charsets are ASCII, so passing non-ASCII
characters from emails to clients would probably confuse clients.

5 years agowwwlisting: require ASCII digit for port number
Eric Wong [Tue, 4 Jun 2019 08:32:27 +0000 (08:32 +0000)]
wwwlisting: require ASCII digit for port number

We only care about the hostname portion for matching,
so this change is probably inconsequential.

5 years agohttp: require SERVER_PORT to be ASCII digit
Eric Wong [Tue, 4 Jun 2019 02:04:26 +0000 (02:04 +0000)]
http: require SERVER_PORT to be ASCII digit

I'm not sure what middlewares care for for SERVER_PORT; but
allowing non-ASCII digits seems non-sensical, here.

5 years agofeed: only accept ASCII digits for ref~$N
Eric Wong [Tue, 4 Jun 2019 02:04:22 +0000 (02:04 +0000)]
feed: only accept ASCII digits for ref~$N

We don't want to waste cycles passing non-ASCII characters
to git.

5 years agomid: id_compress requires ASCII-clean words
Eric Wong [Tue, 4 Jun 2019 02:04:23 +0000 (02:04 +0000)]
mid: id_compress requires ASCII-clean words

Its result is used for HTML anchors and such.

5 years agonntp: ensure we only handle ASCII whitespace
Eric Wong [Tue, 4 Jun 2019 08:20:40 +0000 (08:20 +0000)]
nntp: ensure we only handle ASCII whitespace

RFC3977 does not have provisions for whitespace beyond ASCII
TAB, SP, CR and LF.  I doubt there's any NNTP clients broken
enough to be sending non-ASCII whitespace delimiters.

We're probably excessively liberal regarding TAB acceptance,
even; but it's probably too late to change at this point...

5 years agonntp: be explicit about ASCII digit matches
Eric Wong [Tue, 4 Jun 2019 02:04:25 +0000 (02:04 +0000)]
nntp: be explicit about ASCII digit matches

We aren't able to make sense of non-ASCII digits

cf. perlrecharclass(1) / "Digits" section

5 years agolinkify: support Internationalized Domain Names in URLs
Eric Wong [Tue, 4 Jun 2019 02:04:21 +0000 (02:04 +0000)]
linkify: support Internationalized Domain Names in URLs

The "\w" character class in Perl matches any word characters
in the Unicode database, not just ASCII characters.  So we
must be prepared for that and generate links to IDNs.

5 years agoMerge remote-tracking branch 'origin/git-cleanup'
Eric Wong [Mon, 3 Jun 2019 10:06:04 +0000 (10:06 +0000)]
Merge remote-tracking branch 'origin/git-cleanup'

* origin/git-cleanup:
  git: drop the deleted err_c file
  git: unconditional expiry

5 years agoMerge remote-tracking branch 'origin/ds'
Eric Wong [Mon, 3 Jun 2019 09:04:01 +0000 (09:04 +0000)]
Merge remote-tracking branch 'origin/ds'

* origin/ds:
  ds: remove PLCMap and per-socket PostLoopCallback
  ds: drop write_set_watch field
  ds: drop unused EVENT: label in epoll code path
  ds: drop checks for invalid descriptors
  ds: drop set_writer_func support
  ds: add a note about planned future changes
  ds: drop more unused subs

5 years agods: remove PLCMap and per-socket PostLoopCallback
Eric Wong [Mon, 3 Jun 2019 09:00:28 +0000 (09:00 +0000)]
ds: remove PLCMap and per-socket PostLoopCallback

We don't need and won't be needing per-socket PostLoopCallbacks.