edit: fix portability of editor invocation

The eval was unnecessary, and $0 can't be "--".
Tested with /bin/sh on FreeBSD 11.2

diff --git a/script/public-inbox-edit b/script/public-inbox-edit
index 2e2c761620e154da65a395f6d9c6a12a756cb14f..6884fd0cb276623f64f4e27b7cb5e965c4140256 100755 (executable)
--- a/script/public-inbox-edit
+++ b/script/public-inbox-edit
@@ -138,7 +138,7 @@ foreach my $to_edit (values %$found) {
 
        # run the editor, respecting spaces/quote
 retry_edit:
-       if (system(qw(sh -c), qq(eval "$editor" '"\$@"'), '--', $edit_fn)) {
+       if (system(qw(sh -c), $editor.' "$@"', $editor, $edit_fn)) {
                if (!(-t STDIN) && !$opt->{force}) {
                        die "E: $editor failed: $?\n";
                }