]> Sergey Matveev's repositories - btrtrc.git/commitdiff
Tidy up request heaping comments v1.39.1
authorMatt Joiner <anacrolix@gmail.com>
Mon, 13 Dec 2021 01:12:30 +0000 (12:12 +1100)
committerMatt Joiner <anacrolix@gmail.com>
Mon, 13 Dec 2021 01:12:30 +0000 (12:12 +1100)
requesting.go

index a3a7e1c3a9d5c5b35b7885274ac021d83193a41d..59f6693c26dc84725d3a5ab448e2fba1ac65fe73 100644 (file)
@@ -171,9 +171,6 @@ func (p *Peer) getDesiredRequestState() (desired desiredRequestState) {
                        allowedFast := p.peerAllowedFast.ContainsInt(pieceIndex)
                        p.t.piece(pieceIndex).undirtiedChunksIter.Iter(func(ci request_strategy.ChunkIndex) {
                                r := p.t.pieceRequestIndexOffset(pieceIndex) + ci
-                               // if p.t.pendingRequests.Get(r) != 0 && !p.requestState.Requests.Contains(r) {
-                               //      return
-                               // }
                                if !allowedFast {
                                        // We must signal interest to request this. TODO: We could set interested if the
                                        // peers pieces (minus the allowed fast set) overlap with our missing pieces if
@@ -189,7 +186,7 @@ func (p *Peer) getDesiredRequestState() (desired desiredRequestState) {
                                        }
                                }
                                if p.requestState.Cancelled.Contains(r) {
-                                       // Can't re-request.
+                                       // Can't re-request while awaiting acknowledgement.
                                        return
                                }
                                requestHeap.requestIndexes = append(requestHeap.requestIndexes, r)