www: drop --subject from "git send-email" instructions

[public-inbox.git] / t / pop3d.t

diff --git a/t/pop3d.t b/t/pop3d.t
index d5ccb0d8c5b4922d0e275986e45b604ff384dfff..e5d537671292657b17dd5e75e4151c82ea18993b 100644 (file)
--- a/t/pop3d.t
+++ b/t/pop3d.t
@@ -5,8 +5,9 @@ use v5.12;
 use PublicInbox::TestCommon;
 use Socket qw(IPPROTO_TCP SOL_SOCKET);
 # Net::POP3 is part of the standard library, but distros may split it off...
-require_mods(qw(DBD::SQLite Net::POP3 IO::Socket::SSL File::FcntlLock));
+require_mods(qw(DBD::SQLite Net::POP3 IO::Socket::SSL));
 require_git('2.6'); # for v2
+require_mods(qw(File::FcntlLock)) if $^O !~ /\A(?:linux|freebsd)\z/;
 use_ok 'IO::Socket::SSL';
 use_ok 'PublicInbox::TLS';
 my ($tmpdir, $for_destroy) = tmpdir();
@@ -106,6 +107,8 @@ for my $args (
        my @p3s_args = ($pop3s->sockhost,
                        Port => $pop3s->sockport, SSL => 1, %o);
        my $p3s = Net::POP3->new(@p3s_args);
+       my $capa = $p3s->capa;
+       ok(!exists $capa->{STLS}, 'no STLS CAPA for POP3S');
        ok($p3s->quit, 'QUIT works w/POP3S');
        {
                $p3s = Net::POP3->new(@p3s_args);
@@ -127,7 +130,11 @@ for my $args (
        my $np3 = Net::POP3->new(@np3_args);
        ok($np3->quit, 'plain QUIT works');
        $np3 = Net::POP3->new(@np3_args, %o);
+       $capa = $np3->capa;
+       ok(exists $capa->{STLS}, 'STLS CAPA advertised before STLS');
        ok($np3->starttls, 'STLS works');
+       $capa = $np3->capa;
+       ok(!exists $capa->{STLS}, 'STLS CAPA not advertised after STLS');
        ok($np3->quit, 'QUIT works after STLS');
 
        for my $mailbox (('x'x32)."\@$group", $group, ('a'x32)."\@z.$group") {
@@ -239,9 +246,19 @@ EOF
        my $capa = $oldc->capa;
        ok(defined($capa->{PIPELINING}), 'pipelining supported by CAPA');
        is($capa->{EXPIRE}, 0, 'EXPIRE 0 set');
+       ok(!exists $capa->{STLS}, 'STLS unset w/o daemon certs');
 
-       # clients which see "EXPIRE 0" can elide DELE requests
+       # ensure TOP doesn't trigger "EXPIRE 0" like RETR does (cf. RFC2449)
        my $list = $oldc->list;
+       ok(scalar keys %$list, 'got a listing of messages');
+       ok($oldc->top($_, 1), "TOP $_ 1") for keys %$list;
+       ok($oldc->quit, 'QUIT after TOP');
+
+       # clients which see "EXPIRE 0" can elide DELE requests
+       $oldc = Net::POP3->new(@old_args);
+       ok($oldc->apop("$locked_mb.0", 'anonymous'), 'APOP for RETR');
+       is_deeply($oldc->capa, $capa, 'CAPA unchanged');
+       is_deeply($oldc->list, $list, 'LIST unchanged by previous TOP');
        ok($oldc->get($_), "RETR $_") for keys %$list;
        ok($oldc->quit, 'QUIT after RETR');