]> Sergey Matveev's repositories - public-inbox.git/commit
Import.pm: Don't assume {in} and {out} always exist
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 1 Aug 2018 16:43:32 +0000 (11:43 -0500)
committerEric Wong <e@80x24.org>
Thu, 2 Aug 2018 02:18:07 +0000 (02:18 +0000)
commit9294716ecc685c7b21ec21e2dbbbeb2c8f62c477
treea6c417a32936d0141742af0bafc15627fc1507ed
parent8e0e850859fc9572cf201111728eaa621eace451
Import.pm: Don't assume {in} and {out} always exist

While working on one of the tests I did:
my $im = PublicInbox::V2Writable->new($ibx, 1);
my $im0 = $im->importer();
$im->add($mime);

Which resulted in a warning of the use of an undefined value from
atfork_child, and the test failing nastily.  Inspection of the code
reveals this can happen anytime gfi_start has not been called.

So just fix atfork_child to skip closing file descriptors that have
not yet been setup.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
lib/PublicInbox/Import.pm