]> Sergey Matveev's repositories - public-inbox.git/commitdiff
testcommon: tcp_(server|connect): BAIL_OUT on failure
authorEric Wong <e@yhbt.net>
Wed, 10 Jun 2020 07:04:27 +0000 (07:04 +0000)
committerEric Wong <e@yhbt.net>
Sat, 13 Jun 2020 07:55:45 +0000 (07:55 +0000)
None of our tests rely on this failing, so just bail out
if the system is out of resources.

lib/PublicInbox/TestCommon.pm

index 246047b1357a7db8b43c52e6fad92097f91dcbe8..5e7dc8b0d3fccb00524263ebafa9d61817300bd9 100644 (file)
@@ -37,17 +37,18 @@ sub tcp_server () {
                Type => Socket::SOCK_STREAM(),
                Listen => 1024,
                Blocking => 0,
-       )
+       ) or Test::More::BAIL_OUT("failed to create TCP server: $!");
 }
 
 sub tcp_connect {
        my ($dest, %opt) = @_;
+       my $addr = $dest->sockhost . ':' . $dest->sockport;
        my $s = IO::Socket::INET->new(
                Proto => 'tcp',
                Type => Socket::SOCK_STREAM(),
-               PeerAddr => $dest->sockhost . ':' . $dest->sockport,
+               PeerAddr => $addr,
                %opt,
-       );
+       ) or Test::More::BAIL_OUT("failed to connect to $addr: $!");
        $s->autoflush(1);
        $s;
 }