v2writable: ensure ->done is idempotent

This matches Import::done behavior

diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm
index 36901cdea0c33e69dd538f70f7f0acd40932eb4f..5c104d8ec27df12fa93528834f3d396e401e0691 100644 (file)
--- a/lib/PublicInbox/V2Writable.pm
+++ b/lib/PublicInbox/V2Writable.pm
@@ -249,10 +249,11 @@ sub remove {
 
 sub done {
        my ($self) = @_;
+       my $locked = defined $self->{idx_parts};
        my $im = delete $self->{im};
        $im->done if $im; # PublicInbox::Import::done
        $self->searchidx_checkpoint(0);
-       $self->lock_release;
+       $self->lock_release if $locked;
 }
 
 sub checkpoint {

diff --git a/t/v2writable.t b/t/v2writable.t
index 5245a84b1fbcfaea56bfa63c1fe7e7c14b60298c..771e8c1722efe7df3aa114ed144228c5bee89aa8 100644 (file)
--- a/t/v2writable.t
+++ b/t/v2writable.t
@@ -223,6 +223,8 @@ EOF
        $im->done;
        is($git0->qx(qw(log -1 --pretty=raw --raw -r --no-abbrev)),
                $after, 'no git history made with idempotent remove');
+       eval { $im->done };
+       ok(!$@, '->done is idempotent');
 }
 
 done_testing();