]> Sergey Matveev's repositories - public-inbox.git/commitdiff
view: add [thread overview] anchor next to Date:
authorEric Wong <e@80x24.org>
Wed, 28 Apr 2021 06:55:22 +0000 (06:55 +0000)
committerEric Wong <e@80x24.org>
Wed, 28 Apr 2021 19:30:43 +0000 (19:30 +0000)
The existing Subject: anchor to #r may not be 100% obvious,
and we can't stick the phrase "[thread overview]" into the
same line as the Subject without introducing ambiguity.

Fortunately, we have the Date: header directly under it.
Adding "[thread overview]" after the Date: is unambiguous
and won't make the line too long for valid emails.

This hopefully improves navigation ever-so-slightly thanks
to comments by Son Luong Ngoc.

Reported-by: Son Luong Ngoc <sluongng@gmail.com>
Link: https://public-inbox.org/git/YHhfsqfTJ9NzRwS1@C02YX140LVDN.corpad.adbkng.com/
lib/PublicInbox/View.pm

index f4f6da1128cb7591c971baa6483a73deea52c16e..530c878f70b1b3783ef7824a9b3ca8534c42402e 100644 (file)
@@ -694,7 +694,7 @@ sub _msg_page_prepare_obuf {
        for my $v ($eml->header('Date')) {
                $v = ascii_html($v);
                obfuscate_addrs($obfs_ibx, $v) if $obfs_ibx; # possible :P
-               $rv .= "Date: $v\n";
+               $rv .= qq{Date: $v\t<a\nhref="#r">[thread overview]</a>\n};
        }
        if (!$nr) { # first (and only) message, common case
                $ctx->{-title_html} = join(' - ', @title);
@@ -739,7 +739,8 @@ sub thread_skel ($$$) {
                        $$skel .= SKEL_EXPAND."\n ";
                        $$skel .= ghost_parent('../', $parent) . "\n";
                } else {
-                       $$skel .= '[no followups] '.SKEL_EXPAND."\n";
+                       $$skel .= "<a\nid=r>[no followups]</a> ".
+                                       SKEL_EXPAND."\n";
                }
                $ctx->{next_msg} = undef;
                $ctx->{parent_msg} = $parent;