sub xref_by_tc ($$$) {
my ($xref, $pi_cfg, $smsg) = @_;
my $by_addr = $pi_cfg->{-by_addr};
- my $groups = $pi_cfg->{-by_newsgroup};
my $mid = $smsg->{mid};
for my $f (qw(to cc)) {
my @ibxs = map {
$by_addr->{lc($_)} // ()
} (PublicInbox::Address::emails($smsg->{$f} // ''));
for my $ibx (@ibxs) {
- $groups->{my $ngname = $ibx->{newsgroup}} or next;
+ my $ngname = $ibx->{newsgroup} // next;
next if defined $xref->{$ngname};
$xref->{$ngname} = eval { $ibx->mm->num_for($mid) };
}
my $groups = $pi_config->{-by_newsgroup}; # filled during each_inbox
$pi_config->each_inbox(sub {
my ($ibx) = @_;
- my $ngname = $ibx->{newsgroup} // return;
- if ($ibx->nntp_usable) { # only valid if msgmap and over works
+ my $ngname = $ibx->{newsgroup};
+ if (defined($ngname) && $ibx->nntp_usable) {
+ # only valid if msgmap and over works
# preload to avoid fragmentation:
$ibx->description;
$ibx->base_url;
} else {
delete $groups->{$ngname};
+ delete $ibx->{newsgroup};
+ # Note: don't be tempted to delete more for memory
+ # savings just yet: NNTP, IMAP, and WWW may all
+ # run in the same process someday.
}
});
$self->{groupnames} = [ sort(keys %$groups) ];