]> Sergey Matveev's repositories - public-inbox.git/commitdiff
lei_mirror: defend against infinite loops
authorEric Wong <e@80x24.org>
Mon, 28 Nov 2022 05:31:26 +0000 (05:31 +0000)
committerEric Wong <e@80x24.org>
Mon, 28 Nov 2022 23:38:55 +0000 (23:38 +0000)
A reference chain of 1000 ought to be enough, I think...

lib/PublicInbox/LeiMirror.pm

index 0f46d35531f890ec9bacba93c7ea6f64d336c27c..1d6ed51c80ee5f35d89309f080dfcf67e8d7e868 100644 (file)
@@ -538,9 +538,13 @@ sub clone_all {
        # resolve references, deepest, first:
        while (scalar keys %$todo) {
                for my $x (keys %$todo) {
+                       my $nr;
                        # resolve multi-level references
                        while (defined(my $nxt = $m->{$x}->{reference})) {
                                exists($todo->{$nxt}) or last;
+                               die <<EOM if ++$nr > 1000;
+E: dependency loop detected (`$x' => `$nxt')
+EOM
                                $x = $nxt;
                        }
                        my $y = delete $todo->{$x} // next; # already done