...Instead of just returning a plain scalar inside an arrayref.
This is because we usually pass the result of NNTP::get_range to
Msgmap::msg_range. Upcoming changes will move us away from
anonymous subroutines, so this change will make followup commits
easier-to-digest as modifications to the underlying scalar can
be more easily propagated between non-anonymous-subs.
return $r unless ref $r;
my ($beg, $end) = @$r;
long_response($self, sub {
return $r unless ref $r;
my ($beg, $end) = @$r;
long_response($self, sub {
- $r = $mm->msg_range(\$beg, $end, 'num');
+ $r = $mm->msg_range($beg, $end, 'num');
scalar(@$r) or return;
more($self, join("\r\n", map { $_->[0] } @$r));
1;
scalar(@$r) or return;
more($self, join("\r\n", map { $_->[0] } @$r));
1;
$beg = $min if ($beg < $min);
$end = $max if ($end > $max);
return '420 No article(s) selected' if ($beg > $end);
$beg = $min if ($beg < $min);
$end = $max if ($end > $max);
return '420 No article(s) selected' if ($beg > $end);
}
sub long_response ($$) {
}
sub long_response ($$) {
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
long_response($self, sub {
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
long_response($self, sub {
- my $r = $mm->msg_range(\$beg, $end);
+ my $r = $mm->msg_range($beg, $end);
@$r or return;
more($self, join("\r\n", map {
"$_->[0] <$_->[1]>"
@$r or return;
more($self, join("\r\n", map {
"$_->[0] <$_->[1]>"
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
long_response($self, sub {
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
long_response($self, sub {
- my $r = $mm->msg_range(\$beg, $end);
+ my $r = $mm->msg_range($beg, $end);
@$r or return;
more($self, join("\r\n", map {
my $num = $_->[0];
@$r or return;
more($self, join("\r\n", map {
my $num = $_->[0];
return $r unless ref $r;
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
return $r unless ref $r;
my ($beg, $end) = @$r;
more($self, $xhdr ? r221 : r225);
long_response($self, sub {
my $msgs = $over->query_xover($cur, $end);
my $nr = scalar @$msgs or return;
long_response($self, sub {
my $msgs = $over->query_xover($cur, $end);
my $nr = scalar @$msgs or return;
more($self, '224 Overview information follows');
long_response($self, sub {
more($self, '224 Overview information follows');
long_response($self, sub {
- my $h = over_header_for($over, $beg, 'references');
- more($self, "$beg $h") if defined($h);
- $beg++ < $end;
+ my $h = over_header_for($over, $$beg, 'references');
+ more($self, "$$beg $h") if defined($h);
+ $$beg++ < $end;
my $r = get_range($self, $range);
return $r unless ref $r;
my ($beg, $end) = @$r;
my $r = get_range($self, $range);
return $r unless ref $r;
my ($beg, $end) = @$r;
- more($self, "224 Overview information follows for $beg to $end");
+ more($self, "224 Overview information follows for $$beg to $end");
my $over = $self->{ng}->over;
my $over = $self->{ng}->over;
long_response($self, sub {
my $msgs = $over->query_xover($cur, $end);
my $nr = scalar @$msgs or return;
long_response($self, sub {
my $msgs = $over->query_xover($cur, $end);
my $nr = scalar @$msgs or return;