]> Sergey Matveev's repositories - public-inbox.git/commitdiff
feed: generate_i: eliminate pointless loop
authorEric Wong <e@yhbt.net>
Sun, 5 Jul 2020 23:27:47 +0000 (23:27 +0000)
committerEric Wong <e@yhbt.net>
Mon, 6 Jul 2020 20:01:15 +0000 (20:01 +0000)
$ctx->{msgs} won't ever contain undef values.

lib/PublicInbox/Feed.pm

index b15fc3a09a1157f4937ef80d8ad91ba4a95df5a5..9141faaf08acabfca90c71d7018d2f5b97b16c65 100644 (file)
@@ -11,9 +11,7 @@ use PublicInbox::Smsg; # this loads w/o Search::Xapian
 
 sub generate_i {
        my ($ctx) = @_;
-       while (my $smsg = shift @{$ctx->{msgs}}) {
-               return $smsg;
-       }
+       shift @{$ctx->{msgs}};
 }
 
 # main function