]> Sergey Matveev's repositories - public-inbox.git/commitdiff
http: simplify offset calculation slightly
authorEric Wong <e@80x24.org>
Sat, 27 Feb 2016 02:14:21 +0000 (02:14 +0000)
committerEric Wong <e@80x24.org>
Sat, 27 Feb 2016 10:33:29 +0000 (10:33 +0000)
No point in comparing an empty string; length() is only
potentially expensive on big strings.

lib/PublicInbox/HTTP.pm

index f65dedaae2c5a64e3935b7ef0304b4560387a7b4..f1016d2f0e139cb8460448c1d02102d0ee0ed9b9 100644 (file)
@@ -40,7 +40,7 @@ sub event_read { # called by Danga::Socket
 
        return event_read_input($self) if defined $self->{env};
 
-       my $off = $self->{rbuf} eq '' ? 0 : length($self->{rbuf});
+       my $off = length($self->{rbuf});
        my $r = sysread($self->{sock}, $self->{rbuf}, 8192, $off);
        if (defined $r) {
                return $self->close if $r == 0;