view: thread_html: pass named sub to WwwStream

We can pass everything we need into the WWW $ctx to avoid
allocating kilobytes of memory for an anonymous sub for every
$MESSAGE_ID/t/ request.

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 1e2d3b55c48f53e0eafae768bf6a0758fd29324c..5c64441a8caefd26898512d31d539fd06328cc4d 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -484,17 +484,19 @@ sub thread_html {
        return missing_thread($ctx) unless $smsg;
        $ctx->{-title_html} = ascii_html($smsg->subject);
        $ctx->{-html_tip} = '<pre>'.index_entry($smsg, $ctx, scalar @$msgs);
-       $smsg = undef;
-       PublicInbox::WwwStream->response($ctx, 200, sub {
-               return unless $msgs;
-               $smsg = undef;
-               while (my $m = shift @$msgs) {
-                       $smsg = $ibx->smsg_mime($m) and last;
-               }
-               return index_entry($smsg, $ctx, scalar @$msgs) if $smsg;
-               $msgs = undef;
-               $skel;
-       });
+       $ctx->{msgs} = $msgs;
+       PublicInbox::WwwStream->response($ctx, 200, \&thread_html_i);
+}
+
+sub thread_html_i { # PublicInbox::WwwStream::getline callback
+       my ($nr, $ctx) = @_;
+       my $msgs = $ctx->{msgs} or return;
+       while (my $smsg = shift @$msgs) {
+               $ctx->{-inbox}->smsg_mime($smsg) or next;
+               return index_entry($smsg, $ctx, scalar @$msgs);
+       }
+       my ($skel) = delete @$ctx{qw(dst msgs)};
+       $$skel;
 }
 
 sub multipart_text_as_html {