xt/net_writer_imap: test "lei convert" w/ IMAP source

I just did a double-take and nearly thought authentication
was broken while reading LeiConvert.pm.  Add a comment in
LeiConvert.pm to clarify things, too.

diff --git a/lib/PublicInbox/LeiConvert.pm b/lib/PublicInbox/LeiConvert.pm
index 68fc7c0ba2b0b2932784e5d00bb7602e896a2071..424eab8e22e2d97a4738c88efd60a6c31b218980 100644 (file)
--- a/lib/PublicInbox/LeiConvert.pm
+++ b/lib/PublicInbox/LeiConvert.pm
@@ -55,6 +55,7 @@ sub lei_convert { # the main "lei convert" method
        my $devfd = $lei->path_to_fd($ovv->{dst}) // return;
        $lei->{opt}->{augment} = 1 if $devfd < 0;
        $self->prepare_inputs($lei, \@inputs) or return;
+       # n.b. {net} {auth} is handled by l2m worker
        my ($op_c, $ops) = $lei->workers_start($self, 1);
        $lei->{wq1} = $self;
        $self->wq_io_do('process_inputs', []);

diff --git a/xt/net_writer-imap.t b/xt/net_writer-imap.t
index afa4bcc3e8817bcd31f0c88ebe18378b0b41fbc3..333e0e3b7ee0a7de2eb5c6617fb7eba50bed5ba9 100644 (file)
--- a/xt/net_writer-imap.t
+++ b/xt/net_writer-imap.t
@@ -137,6 +137,13 @@ test_lei(sub {
        is_deeply($res->[0]->[1], $plack_qp_eml,
                        'lei q wrote expected result');
 
+       my $mdir = "$ENV{HOME}/t.mdir";
+       lei_ok 'convert', $folder_url, '-o', $mdir;
+       my @mdfiles = glob("$mdir/*/*");
+       is(scalar(@mdfiles), 1, '1 message from IMAP => Maildir conversion');
+       is_deeply(eml_load($mdfiles[0]), $plack_qp_eml,
+               'conversion from IMAP to Maildir');
+
        lei_ok qw(q f:matz -a -o), $folder_url;
        $nwr->imap_each($folder_uri, $imap_slurp_all, my $aug = []);
        is(scalar(@$aug), 2, '2 results after augment') or diag explain($aug);