Apparently, neither our previous address parsing code nor
Email::Address::XS recognizes local, username-only addresses
in the form of <username> (without "@host"). Without
this change, Email::Address::XS->address would return
"undef", so we need to filter it out via "grep { defined }"
It seems the cases where users email each other on the same
machine is small and public-inbox won't be able to index
addresses for those cases... Oh well :/
use strict;
use warnings;
-sub xs_emails { map { $_->address() } parse_email_addresses($_[0]) }
+sub xs_emails {
+ grep { defined } map { $_->address() } parse_email_addresses($_[0])
+}
sub xs_names {
- map {
+ grep { defined } map {
my $n = $_->name;
- $n = $_->user if $n eq $_->address;
+ my $addr = $_->address;
+ $n = $_->user if defined($addr) && $n eq $addr;
$n;
} parse_email_addresses($_[0]);
}
@names = $names->('"Quote Unneeded" <user@example.com>');
is_deeply(['Quote Unneeded'], \@names, 'extra quotes dropped');
+
+ my @emails = $emails->('Local User <user>');
+ is_deeply([], \@emails , 'no address for local address');
+ @names = $emails->('Local User <user>');
+ is_deeply([], \@names, 'no address, no name');
}
test_pkg('PublicInbox::Address');