]> Sergey Matveev's repositories - public-inbox.git/commitdiff
thread: avoid incrementing undefined value
authorEric Wong <e@80x24.org>
Wed, 5 Oct 2016 23:47:25 +0000 (23:47 +0000)
committerEric Wong <e@80x24.org>
Wed, 5 Oct 2016 23:53:32 +0000 (23:53 +0000)
It is pointless to increment when setting a true value is
simpler as there is no need to read before writing.

lib/PublicInbox/SearchThread.pm

index dad783ef6cdc64b73a7e105750a1dc3d25873563..ba31f4322ae851c23a65fdfe6e96c0a42f28b601 100644 (file)
@@ -179,7 +179,7 @@ sub recurse_down {
        my %seen;
        my @q = ($self);
        while (my $cont = shift @q) {
-               $seen{$cont}++;
+               $seen{$cont} = 1;
                $callback->($cont);
 
                if (my $next = $cont->{next}) {
@@ -209,7 +209,7 @@ sub order_children {
                push @visited, $walk;
 
                # spot/break loops
-               $seen{$walk}++;
+               $seen{$walk} = 1;
 
                my $child = $walk->{child};
                if ($child && $seen{$child}) {