]> Sergey Matveev's repositories - public-inbox.git/commitdiff
www_listing: switch to `print $zfh'
authorEric Wong <e@80x24.org>
Sat, 10 Sep 2022 08:17:28 +0000 (08:17 +0000)
committerEric Wong <e@80x24.org>
Sat, 10 Sep 2022 19:50:57 +0000 (19:50 +0000)
Again, ->deflate (and thus ->zmore) calls are relatively
expensive compared to `print' ops using PerlIO::scalar
behind-the-scenes.  While I can likely optimize the `join' away
here, too, that will happen in a future commit.

lib/PublicInbox/WwwListing.pm

index 35abf05030d8f05d8d40ea6845536d0e59c3046a..72c940ddc406184cc938d48ce649f319bfac6e65 100644 (file)
@@ -208,27 +208,28 @@ sub psgi_triple {
        my $h = [ 'Content-Type', 'text/html; charset=UTF-8',
                        'Content-Length', undef ];
        my $gzf = gzf_maybe($h, $ctx->{env});
-       $gzf->zmore('<html><head><title>public-inbox listing</title>' .
-                       $ctx->{www}->style('+/') .
-                       '</head><body>');
+       my $zfh = $gzf->zfh;
+       print $zfh '<html><head><title>public-inbox listing</title>',
+                       $ctx->{www}->style('+/'),
+                       '</head><body>';
        my $code = 404;
        if (my $list = delete $ctx->{-list}) {
                my $mset = delete $ctx->{-mset};
                $code = 200;
                if ($mset) { # already sorted, so search bar:
-                       $gzf->zmore(mset_nav_top($ctx, $mset));
+                       print $zfh mset_nav_top($ctx, $mset);
                } else { # sort config dump by ->modified
                        @$list = map { $_->[1] }
                                sort { $b->[0] <=> $a->[0] } @$list;
                }
-               $gzf->zmore('<pre>', join("\n", @$list)); # big
-               $gzf->zmore(mset_footer($ctx, $mset)) if $mset;
+               print $zfh '<pre>', join("\n", @$list); # big
+               print $zfh mset_footer($ctx, $mset) if $mset;
        } elsif (my $mset = delete $ctx->{-mset}) {
-               $gzf->zmore(mset_nav_top($ctx, $mset) .
-                               '<pre>no matching inboxes' .
-                               mset_footer($ctx, $mset));
+               print $zfh mset_nav_top($ctx, $mset),
+                               '<pre>no matching inboxes',
+                               mset_footer($ctx, $mset);
        } else {
-               $gzf->zmore('<pre>no inboxes, yet');
+               print $zfh '<pre>no inboxes, yet';
        }
        my $out = $gzf->zflush('</pre><hr><pre>'.
 qq(This is a listing of public inboxes, see the `mirror' link of each inbox