msgiter: msg_part_text returns undef on text/html

We want HTML parts to be downloadable, but not displayed as
unreadable (but injection-safe) HTML source in our own web
and Atom interfaces.

This affects indexing, too, as HTML tags/comments won't be
indexed anymore, but existing indices are only cleaned after
--reindex.  HTML-only mail won't be indexed at all, but we won't
cross that bridge until somebody cares about that crap.   We'll
continue to actively discourage such waste of CPU cycles,
bandwidth, cache and storage.

Fixes: 7d82a8bc04ce2e68 (handle "multipart/mixed" messages which are not multipart')

diff --git a/lib/PublicInbox/MsgIter.pm b/lib/PublicInbox/MsgIter.pm
index d9df32abc37c7fc7da68c0e09ed2f942ddbb4827..6453d9f1043630d267d19c8c1445ef8a288f3abe 100644 (file)
--- a/lib/PublicInbox/MsgIter.pm
+++ b/lib/PublicInbox/MsgIter.pm
@@ -38,6 +38,11 @@ sub msg_iter ($$) {
 sub msg_part_text ($$) {
        my ($part, $ct) = @_;
 
+       # TODO: we may offer a separate sub for people who need to index
+       # HTML-only mail, but the majority of HTML mail is multipart/alternative
+       # with a text part which we don't have to waste cycles decoding
+       return if $ct =~ m!\btext/x?html\b!;
+
        my $s = eval { $part->body_str };
        my $err = $@;