]> Sergey Matveev's repositories - public-inbox.git/commitdiff
nntp: cmd_xrover: use named sub for long_response
authorEric Wong <e@80x24.org>
Sat, 21 Dec 2019 08:00:03 +0000 (08:00 +0000)
committerEric Wong <e@80x24.org>
Sun, 22 Dec 2019 03:56:13 +0000 (03:56 +0000)
Introduce xrover_i which does the same thing as the anonymous
sub it replaces.

lib/PublicInbox/NNTP.pm

index 9e0c1df0827b78100fa465abc049bfb4ca06f71e..95ac7d5fd7ccaddf2dbf505241e006fdf1251ec9 100644 (file)
@@ -803,6 +803,13 @@ sub hdr_mid_response ($$$$$$) {
        undef;
 }
 
+sub xrover_i {
+       my ($self, $beg, $end) = @_;
+       my $h = over_header_for($self->{ng}->over, $$beg, 'references');
+       more($self, "$$beg $h") if defined($h);
+       $$beg++ < $end;
+}
+
 sub cmd_xrover ($;$) {
        my ($self, $range) = @_;
        my $ng = $self->{ng} or return '412 no newsgroup selected';
@@ -812,16 +819,8 @@ sub cmd_xrover ($;$) {
        $range = $self->{article} unless defined $range;
        my $r = get_range($self, $range);
        return $r unless ref $r;
-       my ($beg, $end) = @$r;
-       my $mm = $ng->mm;
-       my $over = $ng->over;
        more($self, '224 Overview information follows');
-
-       long_response($self, sub {
-               my $h = over_header_for($over, $$beg, 'references');
-               more($self, "$$beg $h") if defined($h);
-               $$beg++ < $end;
-       });
+       long_response($self, \&xrover_i, @$r);
 }
 
 sub over_line ($$$$) {