feed: unset GIT_DIR and use "git --git-dir=.. log"

This should elimate all of our %ENV dependencies in the WWW portion
of our code.

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index ad058395ce6c19294d832fc91ee1a162ebce9611..d535cea93c95e6cb63029a900342c0957ec64fff 100644 (file)
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -23,7 +23,6 @@ sub generate {
        require POSIX;
        my $max = $args->{max} || MAX_PER_PAGE;
 
-       local $ENV{GIT_DIR} = $args->{git_dir};
        my $feed_opts = get_feedopts($args);
        my $addr = $feed_opts->{address};
        $addr = $addr->[0] if ref($addr);
@@ -52,7 +51,6 @@ sub generate_html_index {
        require Mail::Thread;
 
        my $max = $args->{max} || MAX_PER_PAGE;
-       local $ENV{GIT_DIR} = $args->{git_dir};
        my $feed_opts = get_feedopts($args);
 
        my $title = $feed_opts->{description} || '';
@@ -130,7 +128,8 @@ sub each_recent_blob {
        # get recent messages
        # we could use git log -z, but, we already know ssoma will not
        # leave us with filenames with spaces in them..
-       my @cmd = qw/git log --no-notes --no-color --raw -r/;
+       my @cmd = ('git', "--git-dir=$args->{git_dir}",
+                       qw/log --no-notes --no-color --raw -r/);
        push @cmd, $range;
 
        my $pid = open(my $log, '-|', @cmd) or