www: avoid warnings on YYYYMMDD-only t= query parameter

While we always generate YYYYMMDDhhmmss query parameters
ourselves, the regexps in paginate_recent allow YYYYMMDD-only
(no hhmmss) timestamps, so don't trigger Time::Local::timegm
warnings about empty numeric comparisons on empty strings when a
client starts making up their own URLs.

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 4cb72bea849e6b28b4bfacc2684af1daf2689128..f23bfcc921563006198ba3a0f33ac8f687745af0 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1147,7 +1147,7 @@ sub ts2str ($) { strftime('%Y%m%d%H%M%S', gmtime($_[0])) };
 
 sub str2ts ($) {
        my ($yyyy, $mon, $dd, $hh, $mm, $ss) = unpack('A4A2A2A2A2A2', $_[0]);
-       timegm($ss, $mm, $hh, $dd, $mon - 1, $yyyy);
+       timegm($ss || 0, $mm || 0, $hh || 0, $dd, $mon - 1, $yyyy);
 }
 
 sub pagination_footer ($$) {

diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 4ab9601c0f91985dfcd20f6876dd13ce17910dc1..11aef5b3380c9c860e50161ae6e83fa83f27af6a 100644 (file)
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -296,6 +296,9 @@ my $client3 = sub {
        }
        $res = $cb->(GET('/v2test/?t=1970'.'01'.'01'.'000000'));
        is($res->code, 404, '404 for out-of-range t= param');
+       @warn = ();
+       $res = $cb->(GET('/v2test/?t=1970'.'01'.'01'));
+       is_deeply(\@warn, [], 'no warnings on YYYYMMDD only');
 };
 test_psgi(sub { $www->call(@_) }, $client3);
 $run_httpd->($client3, 4);