]> Sergey Matveev's repositories - public-inbox.git/commitdiff
feed: (cleanup) avoid redundant ->message call
authorEric Wong <e@80x24.org>
Sun, 7 Sep 2014 22:56:09 +0000 (22:56 +0000)
committerEric Wong <e@80x24.org>
Sun, 7 Sep 2014 22:57:58 +0000 (22:57 +0000)
Avoid redundant subroutine calls as their costs tend to add up.

lib/PublicInbox/Feed.pm

index 1f1c0d6bd98fe5e63be21ca764e5be35cd14acd8..350cc65e866575618ce5537fc240a6c2fa7d6f04 100644 (file)
@@ -286,8 +286,8 @@ sub add_to_feed {
 
 sub dump_msg {
        my ($self, $level, $html, $now, $seen) = @_;
-       if ($self->message) {
-               my $mime = $self->message;
+       my $mime = $self->message;
+       if ($mime) {
                $$html .=
                    PublicInbox::View->index_entry($mime, $now, $level, $seen);
        }