tests: use strict everywhere

The "strict" pragma makes code easier to debug, and we had
undeclared variables as a result in t/watch_maildir_v2.t.
So use it everywhere to be consistent with the rest of our
code.

diff --git a/t/mid.t b/t/mid.t
index 98b0c200ed54841290207d99be020a356112c286..ecac04deaa215d3a6a6eb33627b6609aa0f52c63 100644 (file)
--- a/t/mid.t
+++ b/t/mid.t
@@ -1,5 +1,6 @@
 # Copyright (C) 2016-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
 use Test::More;
 use PublicInbox::MID qw(mid_escape mids references mids_for_index);
 

diff --git a/t/qspawn.t b/t/qspawn.t
index 58c6febb544738e1b99465e8ba74037a812f0681..fc288a2de0bc32ce6be585b4b2dcb23b288001df 100644 (file)
--- a/t/qspawn.t
+++ b/t/qspawn.t
@@ -1,5 +1,6 @@
 # Copyright (C) 2016-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
 use Test::More;
 use_ok 'PublicInbox::Qspawn';
 

diff --git a/t/watch_maildir.t b/t/watch_maildir.t
index e6cd599cafb949a7b155f5b26bb424bb00a2bae3..41d50329ec72bfa940c25aedb1bb2f00e332d3d3 100644 (file)
--- a/t/watch_maildir.t
+++ b/t/watch_maildir.t
@@ -1,5 +1,6 @@
 # Copyright (C) 2016-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
 use Test::More;
 use File::Temp qw/tempdir/;
 use Email::MIME;

diff --git a/t/watch_maildir_v2.t b/t/watch_maildir_v2.t
index 7fe235211a98f46602e72ea6b4be4e64889e2cb3..e0e8a13f4a0f8286bfad02da5b731bf1a3db4a26 100644 (file)
--- a/t/watch_maildir_v2.t
+++ b/t/watch_maildir_v2.t
@@ -1,5 +1,6 @@
 # Copyright (C) 2018-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+use strict;
 use Test::More;
 use File::Temp qw/tempdir/;
 use PublicInbox::MIME;
@@ -106,7 +107,7 @@ More majordomo info at  http://vger.kernel.org/majordomo-info.html\n);
                local $SIG{__WARN__} = sub {}; # quiet spam check warning
                PublicInbox::WatchMaildir->new($config)->scan('full');
        }
-       ($nr, $msgs) = $srch->reopen->query('');
+       my ($nr, $msgs) = $srch->reopen->query('');
        is($nr, 0, 'inbox is still empty');
        is(unlink(glob("$maildir/new/*")), 1);
 }
@@ -119,7 +120,7 @@ More majordomo info at  http://vger.kernel.org/majordomo-info.html\n);
        PublicInbox::Emergency->new($maildir)->prepare(\$msg);
        $config->{'publicinboxwatch.spamcheck'} = 'spamc';
        PublicInbox::WatchMaildir->new($config)->scan('full');
-       ($nr, $msgs) = $srch->reopen->query('');
+       my ($nr, $msgs) = $srch->reopen->query('');
        is($nr, 1, 'inbox has one mail after spamc OK-ed a message');
        my $mref = $ibx->msg_by_smsg($msgs->[0]);
        like($$mref, qr/something\n\z/s, 'message scrubbed on import');
@@ -132,7 +133,7 @@ More majordomo info at  http://vger.kernel.org/majordomo-info.html\n);
        $msg = eval { local $/; <$fh> };
        PublicInbox::Emergency->new($maildir)->prepare(\$msg);
        PublicInbox::WatchMaildir->new($config)->scan('full');
-       ($nr, $msgs) = $srch->reopen->query('dfpost:6e006fd7');
+       my ($nr, $msgs) = $srch->reopen->query('dfpost:6e006fd7');
        is($nr, 1, 'diff postimage found');
        my $post = $msgs->[0];
        ($nr, $msgs) = $srch->query('dfpre:090d998b6c2c');