view: remove last Hval->new caller

The object-oriented Hval API turned out to be less useful and
more clunky than I envisioned years ago, so get rid of it.
We'll no longer strip trailing whitespace from From: headers in
the HTML display, but I doubt anybody cares.

diff --git a/lib/PublicInbox/Hval.pm b/lib/PublicInbox/Hval.pm
index 40c97da478fe6685810afa1c2c866945b70ef7a3..5f7ab513b11d9d3f0cc61459153c6c067f8c0f7d 100644 (file)
--- a/lib/PublicInbox/Hval.pm
+++ b/lib/PublicInbox/Hval.pm
@@ -16,17 +16,6 @@ my $enc_ascii = find_encoding('us-ascii');
 # safe-ish acceptable filename pattern for portability
 our $FN = '[a-zA-Z0-9][a-zA-Z0-9_\-\.]+[a-zA-Z0-9]'; # needs \z anchor
 
-sub new {
-       my ($class, $raw, $href) = @_;
-
-       # we never care about trailing whitespace
-       $raw =~ s/\s*\z//;
-       bless {
-               raw => $raw,
-               href => defined $href ? $href : $raw,
-       }, $class;
-}
-
 sub mid_href { ascii_html(mid_escape($_[0])) }
 
 # some of these overrides are standard C escapes so they're
@@ -71,16 +60,6 @@ sub ascii_html {
        $enc_ascii->encode($s, Encode::HTMLCREF);
 }
 
-sub as_html { ascii_html($_[0]->{raw}) }
-
-sub raw {
-       if (defined $_[1]) {
-               $_[0]->{raw} = $_[1];
-       } else {
-               $_[0]->{raw};
-       }
-}
-
 # returns a protocol-relative URL string
 sub prurl ($$) {
        my ($env, $u) = @_;

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 14b7d81d619a85cb45455334c71abcd9c08d49f5..980f265a06ddb99d9736242473e28a1db7ee894c 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -630,10 +630,9 @@ sub _msg_page_prepare_obuf {
        }
        my @title; # (Subject[0], From[0])
        for my $v ($hdr->header('From')) {
-               $v = PublicInbox::Hval->new($v);
-               my @n = PublicInbox::Address::names($v->raw);
+               my @n = PublicInbox::Address::names($v);
+               $v = ascii_html($v);
                $title[1] //= ascii_html(join(', ', @n));
-               $v = $v->as_html;
                if ($obfs_ibx) {
                        obfuscate_addrs($obfs_ibx, $v);
                        obfuscate_addrs($obfs_ibx, $title[1]);