nntp: reduce allocations for greeting

No need to allocate a new PerlIO::scalar filehandle for every
client, instead we can now pass the same CODE reference which
calls DS->write on a reused string reference.

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 53de2bca2495c7b49b4369dbc1a94ebae7fa41fc..12ce4e687f574e655e9201fda255552f7241ebb1 100644 (file)
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -101,6 +101,8 @@ sub expire_old () {
        }
 }
 
+sub greet ($) { $_[0]->write($_[0]->{nntpd}->{greet}) };
+
 sub new ($$$) {
        my ($class, $sock, $nntpd) = @_;
        my $self = fields::new($class);
@@ -113,9 +115,7 @@ sub new ($$$) {
        }
        $self->SUPER::new($sock, $ev);
        $self->{nntpd} = $nntpd;
-       my $greet = "201 $nntpd->{servername} ready - post via email\r\n";
-       open my $fh, '<:scalar',  \$greet or die "open :scalar: $!";
-       push @$wbuf, $fh;
+       push @$wbuf, \&greet;
        $self->{wbuf} = $wbuf;
        $self->{rbuf} = '';
        update_idle_time($self);

diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm
index 6d9ffd5ffe03b687c863ec5b930f796b9d1dc9f4..4f30c5d9aede1cdbedab3a11bf4b84f4edd8c7e5 100644 (file)
--- a/lib/PublicInbox/NNTPD.pm
+++ b/lib/PublicInbox/NNTPD.pm
@@ -25,6 +25,7 @@ sub new {
                out => \*STDOUT,
                grouplist => [],
                servername => $name,
+               greet => \"201 $name ready - post via email\r\n",
                # accept_tls => { SSL_server => 1, ..., SSL_reuse_ctx => ... }
        }, $class;
 }