]> Sergey Matveev's repositories - public-inbox.git/commitdiff
smsg: parse_references: micro-optimization
authorEric Wong <e@80x24.org>
Sun, 24 Jan 2021 11:46:55 +0000 (04:46 -0700)
committerEric Wong <e@80x24.org>
Sun, 24 Jan 2021 19:46:10 +0000 (15:46 -0400)
With Perl 5.10+, we can rely on the defined-or-assignment (//=)
operator to avoid repeatedly rewriting an SV.

This may not provide a measurable difference here, but
it's more consistent with current style where things like
commit a05445fb400108e60ede7d377cf3b26a0392eb24
("config: config_fh_parse: micro-optimize") provide a measurable
improvement.

lib/PublicInbox/Smsg.pm

index 2b72e8b5ae804e283cbd4711f2a001261da9355c..b4cc2ecb1afe6e4b2a224138cb39a6eff8bdca18 100644 (file)
@@ -83,7 +83,7 @@ sub parse_references ($$$) {
                        warn "References: <$ref> too long, ignoring\n";
                        next;
                }
-               push(@keep, $ref) unless $seen{$ref}++;
+               $seen{$ref} //= push(@keep, $ref);
        }
        $smsg->{references} = '<'.join('> <', @keep).'>' if @keep;
        \@keep;