]> Sergey Matveev's repositories - public-inbox.git/commitdiff
config: _fill: inbox name extraction optimization
authorEric Wong <e@80x24.org>
Wed, 23 Dec 2020 08:38:50 +0000 (08:38 +0000)
committerEric Wong <e@80x24.org>
Wed, 23 Dec 2020 23:46:42 +0000 (23:46 +0000)
Using substr() instead of a string copy + s// substitution here
reduces ->fill_all from 4.00s to 3.88s with 50K inboxes on my
workstation.

lib/PublicInbox/Config.pm

index 577337dc8a024d375be2db4f72cffb0365be2ffb..cd8957a1276bb0fa01becd74bf47c61158aec127 100644 (file)
@@ -424,9 +424,7 @@ EOF
                }
        }
 
-       my $name = $pfx;
-       $name =~ s/\Apublicinbox\.//;
-
+       my $name = substr($pfx, length('publicinbox.'));
        if (!valid_inbox_name($name)) {
                warn "invalid inbox name: '$name'\n";
                return;