extmsg: do not modify shared array via prurl

We cannot modify elements in any shared data strucutures
shared between requests.  Oops!

diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 09ee8d6e3bf98db16874e27c5bf7fee1a310b69d..912a675d1ddc5c66c163e4a682a7fbc3c752fb64 100644 (file)
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -138,8 +138,8 @@ again:
                $code = 300;
                $s .= "\nPerhaps try an external site:\n\n";
                my $env = $cgi->{env};
-               foreach my $u (@EXT_URL) {
-                       $u = PublicInbox::Hval::prurl($env, $u);
+               foreach my $url (@EXT_URL) {
+                       my $u = PublicInbox::Hval::prurl($env, $url);
                        my $r = sprintf($u, $href);
                        my $t = sprintf($u, $html);
                        $s .= qq{<a\nhref="$r">$t</a>\n};