]> Sergey Matveev's repositories - public-inbox.git/commitdiff
githttpbackend: remove ancient compatibility check
authorEric Wong <e@80x24.org>
Tue, 31 Dec 2019 10:30:11 +0000 (10:30 +0000)
committerEric Wong <e@80x24.org>
Wed, 1 Jan 2020 07:50:32 +0000 (07:50 +0000)
The ref() call could be hitting memory leaks on Perl 5.16.x.

It's been 3 years (2016-12-25) since 292ca34140489da2
("githttpbackend: simplify compatibility code") back when
this project was barely known and probably nobody used
examples/public-inbox.psgi...

lib/PublicInbox/GitHTTPBackend.pm

index 8dd27a75e6c625205789b3989e1eee5217872a48..8883ec347c18adef02a3abba7d80b7afab530c88 100644 (file)
@@ -47,9 +47,6 @@ sub r ($;$) {
 sub serve {
        my ($env, $git, $path) = @_;
 
-       # XXX compatibility... ugh, can we stop supporting this?
-       $git = PublicInbox::Git->new($git) unless ref($git);
-
        # Documentation/technical/http-protocol.txt in git.git
        # requires one and exactly one query parameter:
        if ($env->{QUERY_STRING} =~ /\Aservice=git-[A-Za-z0-9_]+-pack\z/ ||