]> Sergey Matveev's repositories - public-inbox.git/commitdiff
httpd: a few comments about some fields we set
authorEric Wong <e@80x24.org>
Wed, 30 Jan 2019 07:39:02 +0000 (07:39 +0000)
committerEric Wong <e@80x24.org>
Wed, 30 Jan 2019 07:40:25 +0000 (07:40 +0000)
Removing 'psgix.input.buffered' could be a possibility in
the future.

lib/PublicInbox/HTTPD.pm

index 38517710a414d00ee36d21b069de90953ffa4b08..b0bf94adf7dda314d3d4bb2d134874334d1d5b75 100644 (file)
@@ -29,9 +29,16 @@ sub new {
                'psgi.run_once'  => Plack::Util::FALSE,
                'psgi.multithread' => Plack::Util::FALSE,
                'psgi.multiprocess' => Plack::Util::TRUE,
+
+               # We don't use this anywhere, but we can support
+               # other PSGI apps which might use it:
                'psgix.input.buffered' => Plack::Util::TRUE,
 
-               # XXX unstable API!
+               # XXX unstable API!, only GitHTTPBackend needs
+               # this to limit git-http-backend(1) parallelism.
+               # The rest of our PSGI code is generic, relying
+               # on "pull" model using "getline" to prevent
+               # over-buffering.
                'pi-httpd.async' => do {
                        no warnings 'once';
                        *pi_httpd_async