Clients should see 404s when attempting to hit files for deleted
branches or tags.
PublicInbox::WwwStream::html_init($ctx);
my $zfh = $ctx->{zfh};
print $zfh "<pre>\$ git log -1 $tip -- $path\n";
PublicInbox::WwwStream::html_init($ctx);
my $zfh = $ctx->{zfh};
print $zfh "<pre>\$ git log -1 $tip -- $path\n";
- say $zfh "found no record of `$path' in git history";
+ say $zfh "found no record of `$path' in git history in `$tip'";
$ctx->{-has_srch} and
say $zfh 'perhaps try searching mail (above)';
$ctx->{-has_srch} and
say $zfh 'perhaps try searching mail (above)';
} else {
my ($H, $h, $s_as) = split(/ /, $$bref, 3);
utf8::decode($s_as);
} else {
my ($H, $h, $s_as) = split(/ /, $$bref, 3);
utf8::decode($s_as);
<a href="$ctx->{-upfx}$H/s/?b=$x">$h</a> $s_as
EOM
}
<a href="$ctx->{-upfx}$H/s/?b=$x">$h</a> $s_as
EOM
}
- delete($ctx->{-wcb})->($ctx->html_done);
+ my $res = $ctx->html_done;
+ $res->[0] = $code;
+ delete($ctx->{-wcb})->($res);
}
sub find_missing {
my ($ctx) = @_;
}
sub find_missing {
my ($ctx) = @_;
+ if ($ctx->{-path} eq '') {
+ my $tip = 'HEAD';
+ $tip = ascii_html($ctx->{qp}->{h}) if defined($ctx->{qp}->{h});
+ PublicInbox::WwwStream::html_init($ctx);
+ print { $ctx->{zfh} } "<pre>`$tip' ref not found</pre>";
+ my $res = $ctx->html_done;
+ $res->[0] = 404;
+ return delete($ctx->{-wcb})->($res);
+ }
my $cmd = ['git', "--git-dir=$ctx->{git}->{git_dir}",
qw(log --no-color -1), '--pretty=%H %h %s (%as)' ];
push @$cmd, $ctx->{qp}->{h} if defined($ctx->{qp}->{h});
push @$cmd, '--';
my $cmd = ['git', "--git-dir=$ctx->{git}->{git_dir}",
qw(log --no-color -1), '--pretty=%H %h %s (%as)' ];
push @$cmd, $ctx->{qp}->{h} if defined($ctx->{qp}->{h});
push @$cmd, '--';
- push @$cmd, $ctx->{-path} if $ctx->{-path} ne '';
- my $qsp = PublicInbox::Qspawn->new($cmd);
+ push @$cmd, $ctx->{-path};
+ my $qsp = PublicInbox::Qspawn->new($cmd, undef,
+ { quiet => 1, 2 => $ctx->{lh} });
$qsp->psgi_qx($ctx->{env}, undef, \&rd_404_log, $ctx);
}
$qsp->psgi_qx($ctx->{env}, undef, \&rd_404_log, $ctx);
}
is($res->code, 200, 'got 200 for a directory');
$got = $res->content;
like($got, qr/\bgit ls-tree\b/, 'ls-tree help shown');
is($res->code, 200, 'got 200 for a directory');
$got = $res->content;
like($got, qr/\bgit ls-tree\b/, 'ls-tree help shown');
+
+ $res = $cb->(GET('/public-inbox/tree/?h=no-branch'));
+ is($res->code, 404, 'got 404 for non-existent ref root');
+ $res = $cb->(GET('/public-inbox/tree/README?h=no-file'));
+ is($res->code, 404, 'got 404 for non-existent ref README');
+ $res = $cb->(GET('/public-inbox/tree/Documentation?h=no-dir'));
+ is($res->code, 404, 'got 404 for non-existent ref directory');
};
test_psgi(sub { $www->call(@_) }, $client);
my $env = { PI_CONFIG => $cfgpath, TMPDIR => $tmpdir };
};
test_psgi(sub { $www->call(@_) }, $client);
my $env = { PI_CONFIG => $cfgpath, TMPDIR => $tmpdir };