lei_mail_sync: forget_folder: simplify code

No need to bump refcounts of {dbh} nor declare extra variables
for a rarely-called function.

diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm
index b63f8dead55154e18dc275d71a263d17cca0d85c..57b56b3cbd6282c22f3ba1fff89968dbc5c1b7df 100644 (file)
--- a/lib/PublicInbox/LeiMailSync.pm
+++ b/lib/PublicInbox/LeiMailSync.pm
@@ -403,13 +403,11 @@ EOF
 
 sub forget_folder {
        my ($self, $folder) = @_;
-       my ($fid, $sth);
-       $fid = delete($self->{fmap}->{$folder}) //
+       my $fid = delete($self->{fmap}->{$folder}) //
                fid_for($self, $folder) // return;
-       my $dbh = $self->{dbh};
-       $dbh->do('DELETE FROM blob2name WHERE fid = ?', undef, $fid);
-       $dbh->do('DELETE FROM blob2num WHERE fid = ?', undef, $fid);
-       $dbh->do('DELETE FROM folders WHERE fid = ?', undef, $fid);
+       for my $t (qw(blob2name blob2num folders)) {
+               $self->{dbh}->do("DELETE FROM $t WHERE fid = ?", undef, $fid);
+       }
 }
 
 # only used for changing canonicalization errors