lei_xsearch: sensible errors for missing/broken externals

I've been creating and destroying lots of externals, lately...

diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm
index 9f7f3885a3a6fce2a120bb23416d109495c324ad..556ffd58ff7c969f536ef179cee01414a92fa4de 100644 (file)
--- a/lib/PublicInbox/LeiXSearch.pm
+++ b/lib/PublicInbox/LeiXSearch.pm
@@ -572,8 +572,11 @@ sub prepare_external {
                die "`\\n' not allowed in `$loc'\n" if index($loc, "\n") >= 0;
                require PublicInbox::Inbox; # v2, v1
                $loc = bless { inboxdir => $loc }, 'PublicInbox::Inbox';
+       } elsif (!-e $loc) {
+               warn "W: $loc gone, perhaps run: lei forget-external $loc\n";
+               return;
        } else {
-               warn "W: ignoring $loc, unable to determine type\n";
+               warn "W: $loc ignored, unable to determine external type\n";
                return;
        }
        push @{$self->{locals}}, $loc;