]> Sergey Matveev's repositories - public-inbox.git/commitdiff
view: dump_topics: better naming of top Subject
authorEric Wong <e@yhbt.net>
Sat, 15 Feb 2020 09:46:35 +0000 (09:46 +0000)
committerEric Wong <e@yhbt.net>
Sun, 16 Feb 2020 00:06:36 +0000 (00:06 +0000)
We use `$top' in other places, so name it to `$top_subj'
consistently for `$subj' and `$prev_subj' comparisons down
the function.

lib/PublicInbox/View.pm

index 45c191dbe6a942a5a0b2e3edf2574d8f482e221b..f04467237eac661af2a596f95c008afee297dcd9 100644 (file)
@@ -1087,13 +1087,13 @@ sub dump_topics {
 
        # sort by recency, this allows new posts to "bump" old topics...
        foreach my $topic (sort { $b->[0] <=> $a->[0] } @$order) {
-               my ($ds, $n, $seen, $top, @ex) = @$topic;
+               my ($ds, $n, $seen, $top_subj, @ex) = @$topic;
                @$topic = ();
-               next unless defined $top;  # ghost topic
-               my $mid = delete $seen->{$top};
+               next unless defined $top_subj;  # ghost topic
+               my $mid = delete $seen->{$top_subj};
                my $href = mid_escape($mid);
-               my $prev_subj = [ split(/ /, $top) ];
-               $top = PublicInbox::Hval->new($top)->as_html;
+               my $prev_subj = [ split(/ /, $top_subj) ];
+               $top_subj = PublicInbox::Hval->new($top_subj)->as_html;
                $ds = fmt_ts($ds);
 
                # $n isn't the total number of posts on the topic,
@@ -1109,7 +1109,7 @@ sub dump_topics {
 
                my $mbox = qq(<a\nhref="$href/t.mbox.gz">mbox.gz</a>);
                my $atom = qq(<a\nhref="$href/t.atom">Atom</a>);
-               my $s = "<a\nhref=\"$href/T/$anchor\">$top</a>\n" .
+               my $s = "<a\nhref=\"$href/T/$anchor\">$top_subj</a>\n" .
                        " $ds UTC $n - $mbox / $atom\n";
                for (my $i = 0; $i < scalar(@ex); $i += 2) {
                        my $level = $ex[$i];