git: show more context info on failures

I'm seeing "read: Connection timed out" from in my syslog from
-httpd.  The fail() calls in PublicInbox::Git seems to be the
only code path of ours which could trigger it...

ETIMEDOUT shouldn't happen on pipes, only sockets; and all of
our socket operations are non-blocking.  So this could be
cgit-wwwhighlight-filter.lua, but that's connecting over
localhost, though on fairly loaded HW.

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 7b2ada243969fd660faca083070d78bb475ea45f..181026c7bc1b726ff562e1b488f3256a0bf98c87 100644 (file)
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -17,6 +17,7 @@ use File::Glob qw(bsd_glob GLOB_NOSORT);
 use Time::HiRes qw(stat);
 use PublicInbox::Spawn qw(popen_rd);
 use PublicInbox::Tmpfile;
+use Carp qw(croak);
 our @EXPORT_OK = qw(git_unquote git_quote);
 our $PIPE_BUFSIZ = 65536; # Linux default
 our $in_cleanup;
@@ -319,7 +320,7 @@ sub cat_async_abort ($) {
 sub fail {
        my ($self, $msg) = @_;
        $self->{inflight} ? cat_async_abort($self) : cleanup($self);
-       die $msg;
+       croak("git $self->{git_dir}: $msg");
 }
 
 sub popen {