wwwstatic: offload error handling to PSGI server

The PSGI server needs to account for ->getline failing
due to disk failures or truncated files, anyways.  So
just die() ourselves and let the PSGI server log and
drop the client.

diff --git a/lib/PublicInbox/WwwStatic.pm b/lib/PublicInbox/WwwStatic.pm
index 917049bb68fde1d49c50d1a4056d5ad9d47aaa35..e1f536f3f21c1d7ce63ea74f140d2646fb1284b1 100644 (file)
--- a/lib/PublicInbox/WwwStatic.pm
+++ b/lib/PublicInbox/WwwStatic.pm
@@ -169,16 +169,7 @@ sub getline {
                return $buf;
        }
        my $m = defined $r ? "EOF with $len bytes left" : "read error: $!";
                return $buf;
        }
        my $m = defined $r ? "EOF with $len bytes left" : "read error: $!";

-       my $env = $self->{env};
-       $env->{'psgi.errors'}->print("$self->{path} $m\n");
-
-       # drop the client on error
-       if (my $io = $env->{'psgix.io'}) {
-               $io->close; # this is likely PublicInbox::DS::close
-       } else { # for some PSGI servers w/o psgix.io
-               die "dropping client socket\n";
-       }
-       undef;
+       die "$self->{path} $m, dropping client socket\n";

 }
 
 sub close {} # noop, called by PSGI server, just let everything go out-of-scope
 }
 
 sub close {} # noop, called by PSGI server, just let everything go out-of-scope