]> Sergey Matveev's repositories - public-inbox.git/commitdiff
searchmsg: get rid of termlist scanning for mid
authorEric Wong <e@80x24.org>
Tue, 8 Jan 2019 11:13:27 +0000 (11:13 +0000)
committerEric Wong <e@80x24.org>
Tue, 8 Jan 2019 19:27:41 +0000 (19:27 +0000)
It doesn't seem to be used anywhere

lib/PublicInbox/SearchMsg.pm

index c7787ea1003db61221c6c2aa0d84ab41f60fd59d..5a2ca83bd1f67fcff365b8b986c8300bbde614a0 100644 (file)
@@ -157,29 +157,17 @@ sub references {
        defined $x ? $x : '';
 }
 
-sub _get_term_val ($$$) {
-       my ($self, $pfx, $re) = @_;
-       my $doc = $self->{doc};
-       my $end = $doc->termlist_end;
-       my $i = $doc->termlist_begin;
-       $i->skip_to($pfx);
-       if ($i != $end) {
-               my $val = $i->get_termname;
-               $val =~ s/$re// and return $val;
-       }
-       undef;
-}
-
 sub mid ($;$) {
        my ($self, $mid) = @_;
 
        if (defined $mid) {
                $self->{mid} = $mid;
-       } elsif (my $rv = $self->{mid}) {
+       } elsif (defined(my $rv = $self->{mid})) {
                $rv;
        } elsif ($self->{doc}) {
-               $self->{mid} = _get_term_val($self, 'Q', qr/\AQ/);
+               die "SHOULD NOT HAPPEN\n";
        } else {
+               die "NO {mime} for mid\n" unless $self->{mime};
                $self->_extract_mid; # v1 w/o Xapian
        }
 }