*view: avoid leading zero in time display of the hour

Avoid the visual noise entirely by using a space instead.

I sometimes have difficulty distinguishing '0' from '8' while
other users may mistake it for an 'O' character.  Most digital
clocks I've seen will omit displaying a leading zero for the
hour, too.

This may also save transfer time by allowing better compression
(since there is a space between the date and time anyways) and
perhaps reduce client rendering time on some displays.

We'll leave the leading zero for minutes since that seems pretty
standard for digital clocks.

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index a15af55ec17777d8f1951eb187ac66c1cc1068ea..7f790902ca4c74e83b024196eafa3c47320b866c 100644 (file)
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -10,7 +10,6 @@ use PublicInbox::Hval;
 use PublicInbox::View;
 use PublicInbox::MID qw(mid2path mid_clean);
 use Email::MIME;
-use POSIX qw/strftime/;
 our $LIM = 50;
 
 sub sres_top_html {
@@ -69,11 +68,11 @@ sub dump_mset {
                my $s = PublicInbox::Hval->new_oneline($smsg->subject);
                my $f = $smsg->from_name;
                $f = PublicInbox::Hval->new_oneline($f)->as_html;
-               my $d = strftime('%Y-%m-%d %H:%M', gmtime($smsg->ts));
+               my $ts = PublicInbox::View::fmt_ts($smsg->ts);
                my $mid = PublicInbox::Hval->new_msgid($smsg->mid)->as_href;
                $$res .= qq{$rank. <b><a\nhref="$mid/">}.
                        $s->as_html . "</a></b>\n";
-               $$res .= "$pfx  - by $f @ $d UTC [$pct%]\n\n";
+               $$res .= "$pfx  - by $f @ $ts UTC [$pct%]\n\n";
        }
 }
 

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index f34e1f36d00e20a47754c6b732e7234d36a62e43..2506c95417fc267b6e6436ca0e0bf7175922104b 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -712,9 +712,11 @@ sub missing_thread {
 sub _msg_date {
        my ($mime) = @_;
        my $ts = $mime->header('X-PI-TS') || msg_timestamp($mime);
-       POSIX::strftime('%Y-%m-%d %H:%M', gmtime($ts));
+       fmt_ts($ts);
 }
 
+sub fmt_ts { POSIX::strftime('%Y-%m-%d %k:%M', gmtime($_[0])) }
+
 sub _inline_header {
        my ($dst, $state, $upfx, $mime, $level) = @_;
        my $pfx = INDENT x ($level - 1);
@@ -865,7 +867,7 @@ sub dump_topics {
                $dst .= "$nl$pfx$dot<a\nhref=\"$mid/t/#u\"><b>$subj</b></a>\n";
 
                my $attr;
-               $ts = POSIX::strftime('%Y-%m-%d %H:%M', gmtime($ts));
+               $ts = fmt_ts($ts);
                if ($n == 1) {
                        $attr = "@ $ts UTC";
                        $n = "";