git: drop the deleted err_c file

No reason to leave that (usually) empty file open after killing off
"cat-file --batch-check".  This wasn't an unbound leak, though,
as respawning the --batch-check process would've clobbered the
old err_c file.

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 9a38d7c8dce83bc0aa13d0ee870ab33924390580..9014e021cedcb9084ac50eea515e0a71119f1e94 100644 (file)
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -211,9 +211,10 @@ sub check {
 }
 
 sub _destroy {
-       my ($self, $in, $out, $pid) = @_;
+       my ($self, $in, $out, $pid, $err) = @_;
        my $p = delete $self->{$pid} or return;
        delete @$self{($in, $out)};
+       delete $self->{$err} if $err; # `err_c'
        waitpid $p, 0;
 }
 
@@ -243,7 +244,7 @@ sub qx {
 sub cleanup {
        my ($self) = @_;
        _destroy($self, qw(in out pid));
-       _destroy($self, qw(in_c out_c pid_c));
+       _destroy($self, qw(in_c out_c pid_c err_c));
        !!($self->{pid} || $self->{pid_c});
 }