gzipfilter: minor cleanups

We currently don't use bytes::length in ->write, so there's no
need to `use bytes'.  Favor `//=' to describe the intent of the
conditional assignment since the C::R::Z::Deflate object is
always truthy.  Also use the local $gz variable to avoid
unnecessary {gz} hash lookups.

diff --git a/lib/PublicInbox/GzipFilter.pm b/lib/PublicInbox/GzipFilter.pm
index 864095862096f423ed0d02e2214087515b60673c..a7355a8dfe0a187d78d4896b2ff34f7efc99a3bc 100644 (file)
--- a/lib/PublicInbox/GzipFilter.pm
+++ b/lib/PublicInbox/GzipFilter.pm
@@ -4,7 +4,6 @@
 # Qspawn filter
 package PublicInbox::GzipFilter;
 use strict;
-use bytes (); # length
 use Compress::Raw::Zlib qw(Z_FINISH Z_OK);
 my %OPT = (-WindowBits => 15 + 16, -AppendOutput => 1);
 
@@ -24,21 +23,21 @@ sub translate ($$) {
        # allocate the zlib context lazily here, instead of in ->new.
        # Deflate contexts are memory-intensive and this object may
        # be sitting in the Qspawn limiter queue for a while.
-       my $gz = $self->{gz} ||= do {
+       my $gz = $self->{gz} //= do {
                my ($g, $err) = Compress::Raw::Zlib::Deflate->new(%OPT);
                $err == Z_OK or die "Deflate->new failed: $err";
                $g;
        };
        my $zbuf = delete($self->{zbuf});
        if (defined $_[1]) { # my $buf = $_[1];
-               my $err = $self->{gz}->deflate($_[1], $zbuf);
+               my $err = $gz->deflate($_[1], $zbuf);
                die "gzip->deflate: $err" if $err != Z_OK;
                return $zbuf if length($zbuf) >= 8192;
 
                $self->{zbuf} = $zbuf;
                '';
        } else { # undef == EOF
-               my $err = $self->{gz}->flush($zbuf, Z_FINISH);
+               my $err = $gz->flush($zbuf, Z_FINISH);
                die "gzip->flush: $err" if $err != Z_OK;
                $zbuf;
        }