]> Sergey Matveev's repositories - public-inbox.git/commitdiff
http: remove unnecessary delete
authorEric Wong <e@80x24.org>
Tue, 17 Sep 2019 08:31:23 +0000 (08:31 +0000)
committerEric Wong <e@80x24.org>
Tue, 17 Sep 2019 08:31:49 +0000 (08:31 +0000)
Only removing $http->{env} is needed to prevent circular
references.  $env->{'psgix.io'} does not need to be deleted
since $env will no longer have any references to it when
->close returns.

lib/PublicInbox/HTTP.pm

index cd95f4ab74bc59a9caaa98643db372517f8fe2f6..009b5ff070725c7ce6555bd239e30bffb4360496 100644 (file)
@@ -453,9 +453,7 @@ sub quit {
 
 sub close {
        my $self = $_[0];
-       if (my $env = delete $self->{env}) {
-               delete $env->{'psgix.io'}; # prevent circular references
-       }
+       delete $self->{env}; # prevent circular references
        if (my $forward = delete $self->{forward}) {
                eval { $forward->close };
                err($self, "forward ->close error: $@") if $@;