We don't need to keep an empty buffer around in the common case
when a client is sending us completely inflatable requests and
we're able to read them in one go.
This only seems to save about 2M with 10K NNTPS clients using
COMPRESS, so it's not a huge win, but better than nothing.
unlock_hash(%$self);
$self->res('206 Compression active');
bless $self, $class;
unlock_hash(%$self);
$self->res('206 Compression active');
bless $self, $class;
- $self->{zin} = [ $in, '' ];
}
# overrides PublicInbox::NNTP::compressed
}
# overrides PublicInbox::NNTP::compressed
my ($self, $rbuf, $len, $off) = @_;
my $zin = $self->{zin} or return; # closed
my ($self, $rbuf, $len, $off) = @_;
my $zin = $self->{zin} or return; # closed
- my $deflated = \($zin->[1]);
- my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return;
+ my $doff;
+ my $dbuf = delete($self->{dbuf}) // '';
+ $doff = length($dbuf);
+ my $r = PublicInbox::DS::do_read($self, \$dbuf, $len, $doff) or return;
# assert(length($$rbuf) == $off) as far as NNTP.pm is concerned
# assert(length($$rbuf) == $off) as far as NNTP.pm is concerned
- # -ConsumeInput is true, so $deflated is automatically emptied
- my $err = $zin->[0]->inflate($deflated, $rbuf);
+ # -ConsumeInput is true, so $dbuf is automatically emptied
+ my $err = $zin->inflate($dbuf, $rbuf);
+ $self->{dbuf} = $dbuf if $dbuf ne '';
$r = length($$rbuf) and return $r;
# nothing ready, yet, get more, later
$self->requeue;
$r = length($$rbuf) and return $r;
# nothing ready, yet, get more, later
$self->requeue;