]> Sergey Matveev's repositories - public-inbox.git/commitdiff
thread: reduce indentation level
authorEric Wong <e@80x24.org>
Thu, 13 Oct 2016 03:59:02 +0000 (03:59 +0000)
committerEric Wong <e@80x24.org>
Thu, 13 Oct 2016 04:01:16 +0000 (04:01 +0000)
This should reduce differences from the original Mail::Thread
code and hopefully make things easier-to-follow.

lib/PublicInbox/SearchThread.pm

index 003a8d118fc5e6d3a2db6ac7d6116f2f8edd89b2..c6bd999c050038c52bf16589566a09c7499572ef 100644 (file)
@@ -49,27 +49,27 @@ sub _add_message ($$) {
        $this->{smsg} = $smsg;
 
        # B. For each element in the message's References field:
+       defined(my $refs = $smsg->{references}) or return;
+
        my $prev;
-       if (defined(my $refs = $smsg->{references})) {
-               foreach my $ref ($refs =~ m/<([^>]+)>/g) {
-                       # Find a Container object for the given Message-ID
-                       my $cont = _get_cont_for_id($self, $ref);
-
-                       # Link the References field's Containers together in
-                       # the order implied by the References header
-                       #
-                       # * If they are already linked don't change the
-                       #   existing links
-                       # * Do not add a link if adding that link would
-                       #   introduce a loop...
-                       if ($prev &&
-                               !$cont->{parent} &&  # already linked
-                               !$cont->has_descendent($prev) # would loop
-                          ) {
-                               $prev->add_child($cont);
-                       }
-                       $prev = $cont;
+       foreach my $ref ($refs =~ m/<([^>]+)>/g) {
+               # Find a Container object for the given Message-ID
+               my $cont = _get_cont_for_id($self, $ref);
+
+               # Link the References field's Containers together in
+               # the order implied by the References header
+               #
+               # * If they are already linked don't change the
+               #   existing links
+               # * Do not add a link if adding that link would
+               #   introduce a loop...
+               if ($prev &&
+                       !$cont->{parent} &&  # already linked
+                       !$cont->has_descendent($prev) # would loop
+                  ) {
+                       $prev->add_child($cont);
                }
+               $prev = $cont;
        }
 
        # C. Set the parent of this message to be the last element in