]> Sergey Matveev's repositories - public-inbox.git/commitdiff
lei_mirror: support {symlinks} from manifest
authorEric Wong <e@80x24.org>
Mon, 28 Nov 2022 05:32:23 +0000 (05:32 +0000)
committerEric Wong <e@80x24.org>
Mon, 28 Nov 2022 23:38:59 +0000 (23:38 +0000)
It's part of grokmirror, and useful for keeping compatibility.
We can make use of File::Spec->abs2rel here to ensure our
symlinks are relative and the entire mirror can be copied
as a whole.

lib/PublicInbox/LeiMirror.pm

index fc5bc88d86acba0edff1f3c68c13ed9caf93a0a6..47db9ccd8c3ef8e002d3e034a4b81679d278c766 100644 (file)
@@ -664,6 +664,7 @@ sub up_fp_done {
        push @{$self->{chg}->{fp_mismatch}}, $self->{-key};
 }
 
+# modifies the to-be-written manifest entry, and sets values from it, too
 sub update_ent {
        my ($self) = @_;
        my $key = $self->{-key} // die 'BUG: no -key';
@@ -694,7 +695,26 @@ sub update_ent {
                }
                start_cmd($self, $cmd, { 2 => $self->{lei}->{2} }) if $cmd;
        }
-
+       if (my $symlinks = $self->{-ent}->{symlinks}) {
+               my $top = File::Spec->rel2abs($self->{dst});
+               for my $p (@$symlinks) {
+                       my $ln = "$top/$p";
+                       $ln =~ tr!/!/!s;
+                       my (undef, $dn, $bn) = File::Spec->splitpath($ln);
+                       File::Path::mkpath($dn);
+                       my $tgt = "$top/$key";
+                       $tgt = File::Spec->abs2rel($tgt, $dn);
+                       if (lstat($ln)) {
+                               if (-l _) {
+                                       next if readlink($ln) eq $tgt;
+                                       unlink($ln) or die "unlink($ln): $!";
+                               } else {
+                                       push @{$self->{chg}->{badlink}}, $p;
+                               }
+                       }
+                       symlink($tgt, $ln) or die "symlink($tgt, $ln): $!";
+               }
+       }
        $new = $self->{-ent}->{owner} // return;
        $cur = $self->{-local_manifest}->{$key}->{owner} // "\0";
        return if $cur eq $new;
@@ -1059,6 +1079,10 @@ W: The above fingerprints may never match without --prune
 EOM
        }
        dump_manifest($m => $ft) if delete($self->{chg}->{manifest}) || $mis;
+       my $bad = delete $self->{chg}->{badlink};
+       warn(<<EOM, map { ("\t", $_, "\n") } @$bad) if $bad;
+W: The following exist and have not been converted to symlinks
+EOM
        ft_rename($ft, $manifest, 0666);
 }