]> Sergey Matveev's repositories - public-inbox.git/commitdiff
lei_mirror: break circular references
authorEric Wong <e@80x24.org>
Mon, 12 Dec 2022 09:58:54 +0000 (09:58 +0000)
committerEric Wong <e@80x24.org>
Mon, 12 Dec 2022 20:57:56 +0000 (20:57 +0000)
It seems more graceful than dying and breaking a mirror, since
the {reference} in util-linux was irrelevant anyways with the
move to forkgroups.

lib/PublicInbox/LeiMirror.pm

index d6d2c69eb90e981b57eeafbf7f8f8bf7576c769d..92156cf1cca8b250675bbbebba67971059ac7459 100644 (file)
@@ -960,9 +960,13 @@ sub clone_all {
                        # resolve multi-level references
                        while ($m && defined($nxt = $m->{$x}->{reference})) {
                                exists($todo->{$nxt}) or last;
-                               die <<EOM if ++$nr > 1000;
-E: dependency loop detected (`$x' => `$nxt')
+                               if (++$nr > 1000) {
+                                       $m->{$x}->{reference} = undef;
+                                       $m->{$nxt}->{reference} = undef;
+                                       warn <<EOM
+E: dependency loop detected (`$x' => `$nxt'), breaking
 EOM
+                               }
                                $x = $nxt;
                        }
                        my $y = delete $todo->{$x} // next; # already done