www: comments for denoting Plack::Request vs CGI

We'll probably want to continue supporting CGI for mod_perl
compatibility.

diff --git a/lib/PublicInbox/ExtMsg.pm b/lib/PublicInbox/ExtMsg.pm
index 59bbae595e3b1b214a507ac58a9da6213875c31f..a56df335d61adcf3217b9848f9d16944c570c730 100644 (file)
--- a/lib/PublicInbox/ExtMsg.pm
+++ b/lib/PublicInbox/ExtMsg.pm
@@ -89,7 +89,7 @@ sub ext_msg {
 again:
                my $cgi = $ctx->{cgi};
                my $url = ref($cgi) eq 'CGI' ? $cgi->url(-base) . '/'
-                                       : $cgi->base->as_string;
+                               : $cgi->base->as_string; # Plack::Request
                $url .= $listname;
                unshift @pfx, { git_dir => $ctx->{git_dir}, url => $url };
                foreach my $pfx (@pfx) {

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 5708b60e36141188f21fd5a4522ae187777adc02..65514eb6797abdd464824ffd94d40509270e91ec 100644 (file)
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -287,7 +287,7 @@ sub get_feedopts {
                my $base;
                if (ref($cgi) eq 'CGI') {
                        $base = $cgi->url(-base);
-               } else {
+               } else { # Plack::Request
                        $base = $cgi->base->as_string;
                        $base =~ s!/\z!!;
                }

diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index b4c050b1069286e7bfb33e5b4e38a19f3b1fcc7e..411db16f4eaffaaee7f788b0fb356d3751884ffd 100644 (file)
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -198,6 +198,7 @@ sub get_thread {
 
 sub self_url {
        my ($cgi) = @_;
+                                               # Plack::Request
        ref($cgi) eq 'CGI' ? $cgi->self_url : $cgi->uri->as_string;
 }
 
@@ -362,7 +363,7 @@ sub r301 {
        if (ref($cgi) eq 'CGI') {
                $url = $cgi->url(-base) . '/';
                $qs = $cgi->query_string;
-       } else {
+       } else { # Plack::Request
                $url = $cgi->base->as_string;
                $qs = $cgi->env->{QUERY_STRING};
        }