]> Sergey Matveev's repositories - public-inbox.git/commitdiff
xt/solver: skip on missing publicinbox.git.coderepo
authorEric Wong <e@80x24.org>
Mon, 10 Oct 2022 21:34:21 +0000 (21:34 +0000)
committerEric Wong <e@80x24.org>
Mon, 10 Oct 2022 22:18:26 +0000 (22:18 +0000)
Solver tests can never succeed without coderepos configured,
since that's the whole point of solver.  And improve the
original skip message to note that it's about the `git'
public-inbox, not `git' itself.

xt/solver.t

index c76e0b0a5fc12e88b61fef813c2ac45851d72016..cd894edded8bff6c76869cf758022b0509a61f14 100644 (file)
@@ -48,9 +48,16 @@ my $client = sub {
 my $nr = 0;
 while (($ibx_name, $urls) = each %$todo) {
        SKIP: {
-               if (!$cfg->lookup_name($ibx_name)) {
+               my $ibx = $cfg->lookup_name($ibx_name);
+               if (!$ibx) {
                        push @gone, $ibx_name;
-                       skip("$ibx_name not configured", scalar(@$urls));
+                       skip(qq{[publicinbox "$ibx_name"] not configured},
+                               scalar(@$urls));
+               }
+               if (!defined($ibx->{coderepo})) {
+                       push @gone, $ibx_name;
+                       skip(qq{publicinbox.$ibx_name.coderepo not configured},
+                               scalar(@$urls));
                }
                test_psgi($app, $client);
                $nr++;