]> Sergey Matveev's repositories - public-inbox.git/commitdiff
view: html_footer: avoid escaping " in a few places
authorEric Wong <e@80x24.org>
Sat, 10 Sep 2022 08:17:14 +0000 (08:17 +0000)
committerEric Wong <e@80x24.org>
Sat, 10 Sep 2022 19:50:43 +0000 (19:50 +0000)
qq() is a nice alternative to "" when there's embedded "
characters in HTML entities.

lib/PublicInbox/View.pm

index 40b4bf360213dddc1c8a021a66154d0c127ed2a2..2f99179e969f99e891e4139ddeb5561375fe4ee8 100644 (file)
@@ -819,23 +819,23 @@ EOF
 
                if (my $n = $ctx->{next_msg}) {
                        $n = mid_href($n);
-                       $next = "<a\nhref=\"$upfx$n/\"\nrel=next>next</a>";
+                       $next = qq(<a\nhref="$upfx$n/"\nrel=next>next</a>);
                }
                my $par = $ctx->{parent_msg};
                my $u = $par ? $upfx.mid_href($par).'/' : undef;
                if (my $p = $ctx->{prev_msg}) {
                        $prev = mid_href($p);
                        if ($p && $par && $p eq $par) {
-                               $prev = "<a\nhref=\"$upfx$prev/\"\n" .
+                               $prev = qq(<a\nhref="$upfx$prev/"\n) .
                                        'rel=prev>prev parent</a>';
                                $parent = '';
                        } else {
-                               $prev = "<a\nhref=\"$upfx$prev/\"\n" .
+                               $prev = qq(<a\nhref="$upfx$prev/"\n) .
                                        'rel=prev>prev</a>';
-                               $parent = " <a\nhref=\"$u\">parent</a>" if $u;
+                               $parent = qq( <a\nhref="$u">parent</a>) if $u;
                        }
                } elsif ($u) { # unlikely
-                       $parent = " <a\nhref=\"$u\"\nrel=prev>parent</a>";
+                       $parent = qq( <a\nhref="$u"\nrel=prev>parent</a>);
                }
                $foot .= "$next $prev$parent ";
        } else { # unindexed inboxes w/o over